Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: V2 authn config + redis #3852

Merged
merged 15 commits into from
Jan 28, 2025
Merged

feat: V2 authn config + redis #3852

merged 15 commits into from
Jan 28, 2025

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Jan 28, 2025

Re: #3831

This PR does the following:

  • refactors authentication config to add session.storage with support for memory or redis atm
  • implements redis authentication store
  • removes cleanup for authentication storage as I think this can be handled implicitly by the session stores (ie delete expired tokens automatically via TTLs) we could probably still make the grace period a thing though.
  • adds storage tests for the redis store using the existing (modified) auth testing harness

TODO

  • implement TTL/auto cleanup in the memory session store
  • wire up the redis store in grpc/authn server if configured

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its looking great. One naming thing.

@markphelps markphelps marked this pull request as ready for review January 28, 2025 17:21
@markphelps markphelps requested a review from a team as a code owner January 28, 2025 17:21
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 28, 2025
@markphelps markphelps requested a review from GeorgeMac January 28, 2025 17:48
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
@markphelps markphelps merged commit 9ebc0a1 into v2 Jan 28, 2025
6 of 27 checks passed
@markphelps markphelps deleted the v2-authn branch January 28, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants