Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: start moving over ofrep impl #3949

Draft
wants to merge 2 commits into
base: v2
Choose a base branch
from
Draft

chore: start moving over ofrep impl #3949

wants to merge 2 commits into from

Conversation

markphelps
Copy link
Collaborator

add back and wire up ofrep implementation and ITs

TODO

  • port over previous evaluation tests to bridge_tests

Copy link
Contributor

The latest Buf updates on your PR. Results from workflow Proto / proto-lint (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed❌ failed (3)Feb 25, 2025, 10:01 PM

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 36.19632% with 104 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2@51c9c94). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/server/evaluation/ofrep_bridge.go 30.21% 91 Missing and 6 partials ⚠️
internal/server/evaluation/ofrep/server.go 73.91% 6 Missing ⚠️
internal/cmd/grpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #3949   +/-   ##
=====================================
  Coverage      ?   52.31%           
=====================================
  Files         ?      113           
  Lines         ?    10618           
  Branches      ?        0           
=====================================
  Hits          ?     5555           
  Misses        ?     4678           
  Partials      ?      385           
Flag Coverage Δ
unittests 52.31% <36.19%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant