Skip to content

Commit

Permalink
update release flow (#1728)
Browse files Browse the repository at this point in the history
* update build deps

* update macos runner

* try mac build

* rename env

* add apple team id

* enable all builds

* try to fix notarizing

* finish up

* clean up deps, test build

* fix logger dependency version, test bundling

* cleanup
  • Loading branch information
mholtzman authored Jan 17, 2025
1 parent 24382d6 commit 5e670b5
Show file tree
Hide file tree
Showing 6 changed files with 7,695 additions and 5,592 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,12 @@ jobs:
os:
- ubuntu-latest
include:
- os: macos-11
- os: macos-13
cert_key: APPLE_DEVELOPER_SIGNING_CERTIFICATE
cert_password_key: APPLE_CERTIFICATE_PASSWORD
apple_id_key: APPLE_ID
apple_app_specific_password_key: APPLE_ID_PASSWORD
apple_team_id_key: APPLE_TEAM_ID
- os: windows-latest
cert_key: WINDOWS_CSC_CERTIFICATE
cert_password_key: WINDOWS_CSC_PASSWORD
Expand All @@ -53,7 +54,8 @@ jobs:
CSC_LINK: ${{ secrets[matrix.cert_key] }}
CSC_KEY_PASSWORD: ${{ secrets[matrix.cert_password_key] }}
APPLE_ID: ${{ secrets[matrix.apple_id_key] }}
APPLE_ID_PASSWORD: ${{ secrets[matrix.apple_app_specific_password_key] }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets[matrix.apple_app_specific_password_key] }}
APPLE_TEAM_ID: ${{ secrets[matrix.apple_team_id_key] }}

steps:
- uses: actions/checkout@v4
Expand All @@ -66,6 +68,10 @@ jobs:
run: |
sudo apt update -y
sudo apt install -y libudev-dev
- name: install Macos dev tools
if: matrix.os == 'macos-13'
run: |
sudo -H pip install setuptools
- name: create NPM config file
run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_AUTH_TOKEN }}" > ./.npmrc
- run: npm run setup:ci
Expand Down
3 changes: 3 additions & 0 deletions .parcelrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,8 @@
// Parcel uses its own transpiler
// override the default Parcel config to exclude babel
"*.{js,mjs,jsx,cjs,ts,tsx}": ["@parcel/transformer-js", "@parcel/transformer-react-refresh-wrap"]
},
"optimizers": {
"*.svg": []
}
}
4 changes: 3 additions & 1 deletion build/notarize.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ module.exports = async function (params) {

try {
await electronNotarize.notarize({
tool: 'notarytool',
appBundleId: appId,
appPath: appPath,
appleId: process.env.APPLE_ID,
appleIdPassword: process.env.APPLE_ID_PASSWORD
appleIdPassword: process.env.APPLE_APP_SPECIFIC_PASSWORD,
teamId: process.env.APPLE_TEAM_ID
})

// verify signed and notarized application
Expand Down
1 change: 1 addition & 0 deletions electron-builder.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"target": "default",
"arch": ["x64", "arm64"]
},
"notarize": false,
"hardenedRuntime": true,
"gatekeeperAssess": false,
"entitlements": "build/entitlements.mac.plist",
Expand Down
Loading

0 comments on commit 5e670b5

Please sign in to comment.