Skip to content

Commit

Permalink
typecheck testfiles and storybook files as well
Browse files Browse the repository at this point in the history
  • Loading branch information
ZzAve committed Jan 8, 2025
1 parent a2f02b4 commit 92ab05c
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 20 deletions.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import React from "react";
import { render, screen, cleanup } from "@testing-library/react";
import "@testing-library/jest-dom";
import { ExpensesCard } from "./ExpensesCard.tsx";
import { ExpensesCard } from "./ExpensesCard";
import {
createTestCostExpense,
createTestTravelExpense,
} from "../../utils/tests/test-models";
import dayjs from "dayjs";
import { Status } from "../../models/Status";
import { CostExpense, TravelExpense } from "../../models/Expense";

describe("ExpensesCard", () => {
const testExpense001 = createTestCostExpense("item-01", dayjs());
Expand Down Expand Up @@ -36,7 +37,7 @@ describe("ExpensesCard", () => {
Status.REJECTED
);

const expenses = [
const expenses: (CostExpense | TravelExpense)[] = [
testExpense001,
testExpense002,
testExpense003,
Expand All @@ -50,7 +51,7 @@ describe("ExpensesCard", () => {
});

describe("without expenses", () => {
let expenseCardElement;
let expenseCardElement: HTMLElement | null;
beforeEach(() => {
render(<ExpensesCard items={[]} />);
expenseCardElement = screen.queryByTestId("expenses-card");
Expand All @@ -69,7 +70,7 @@ describe("ExpensesCard", () => {
});

describe("with expenses", () => {
let expenseCardElement;
let expenseCardElement: HTMLElement | null;
beforeEach(() => {
render(<ExpensesCard items={expenses} />);
expenseCardElement = screen.queryByTestId("expenses-card");
Expand Down
8 changes: 4 additions & 4 deletions src/main/react/components/holiday-card/HolidayCard.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Card, CardContent, CardHeader } from "@material-ui/core";
import { Card, CardContent, CardHeader, Typography } from "@material-ui/core";
import React, { useEffect, useState } from "react";
import { PersonHolidayDetails } from "../../clients/AggregationClient";
import { hoursFormatter } from "../../utils/Hours";
Expand All @@ -14,7 +14,7 @@ const useStyles = makeStyles(() => ({
display: "flex",
flexDirection: "row",
justifyContent: "center",
alignItems: "baseline",
alignItems: "center",
"@container (max-width: 500px)": {
flexDirection: "column",
alignItems: "center",
Expand Down Expand Up @@ -74,13 +74,13 @@ export function HolidayCard({ item }: HolidayCardProps) {
<CardHeader title={"Leave days"} />
<CardContent className={classes.containerWrapper}>
<div className={classes.hoursLeftWrapper}>
<span>You have</span>
<Typography variant="body1">You have</Typography>
<div className={classes.hoursLeft}>
<span className={highLightClasses.highlight}>
{hoursFormatter.format(available)}
</span>
</div>
<span>hours left</span>
<Typography variant="body1">hours left</Typography>
</div>
</CardContent>
</Card>
Expand Down
1 change: 1 addition & 0 deletions src/main/react/theme/theme-light.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export const themeLight = createTheme({
export const highLightClass = makeStyles((theme) => ({
highlight: {
position: "relative",
fontFamily: theme.typography.fontFamily,
"&::before": {
content: '""',
backgroundColor: theme.palette.primary.main,
Expand Down
10 changes: 4 additions & 6 deletions src/storybook/components/contracts/ContractsEnding.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,11 @@ const meta: Meta<typeof ContractsEnding> = {
shirtSize: "M",
user: "4dbc2ac4-fc48-4511-a189-bf0d79f7e898",
fullName: "Bert Muppets",
receiveEmail: false,
googleDriveId: "",
},
from: dayjs("2022-10-16"),
to: dayjs("2023-11-24"),
hourlyRate: 80.0,
hoursPerWeek: 40,
billable: true,
type: "EXTERNAL",
},
],
Expand Down Expand Up @@ -69,12 +68,11 @@ export const within6weeks: Story = {
shirtSize: "M",
user: "4dbc2ac4-fc48-4511-a189-bf0d79f7e898",
fullName: "Bert Muppets",
receiveEmail: false,
googleDriveId: "",
},
from: dayjs("2022-10-16"),
to: dayjs("2023-11-24"),
hourlyRate: 80.0,
hoursPerWeek: 40,
billable: true,
type: "EXTERNAL",
},
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ export const withDefaultHours: Story = {};

export const noData: Story = {
args: {
item: {},
item: undefined,
},
};
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Meta, StoryObj } from "@storybook/react";
import { EventList } from "../../../main/react/components/upcoming-events/EventList";
import dayjs from "dayjs";
import { EventType } from "../../../main/react/clients/EventClient";

const meta: Meta<typeof EventList> = {
component: EventList,
Expand All @@ -20,6 +21,7 @@ export const withData: Story = {
{
description: "Super nice event that takes place!",
id: 2712,
type: EventType.GENERAL_EVENT,
code: "event-code",
from: dayjs(),
to: dayjs().add(1, "day"),
Expand All @@ -31,6 +33,7 @@ export const withData: Story = {
{
description: "Smashing Conference - Freiburg",
id: 2712,
type: EventType.GENERAL_EVENT,
code: "event-code",
from: dayjs(),
to: dayjs().add(4, "day"),
Expand All @@ -42,6 +45,7 @@ export const withData: Story = {
{
description: "FLock Hack Day - Flock HQ.",
id: 2712,
type: EventType.GENERAL_EVENT,
code: "event-code",
from: dayjs(),
to: dayjs(),
Expand All @@ -53,6 +57,7 @@ export const withData: Story = {
{
description: "FLock Hack Day - Flock HQ.",
id: 2712,
type: EventType.GENERAL_EVENT,
code: "event-code",
from: dayjs(),
to: dayjs(),
Expand All @@ -64,6 +69,7 @@ export const withData: Story = {
{
description: "Random event- Flock HQ.",
id: 2712,
type: EventType.GENERAL_EVENT,
code: "event-code",
from: dayjs(),
to: dayjs(),
Expand Down
6 changes: 1 addition & 5 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,5 @@
"jsx": "react",
"noImplicitAny": false
},
"exclude": [
"node_modules",
"**/*.stories.tsx",
"**/*.spec.ts"
]
"exclude": ["node_modules"]
}

0 comments on commit 92ab05c

Please sign in to comment.