Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run maven-source-plugin attach-sources with jar-no-fork #99

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

ZzAve
Copy link
Collaborator

@ZzAve ZzAve commented Jan 21, 2024

As a follow up of #95 , here we apply the changes correctly to master (missed it due to PR / rebase hell).

Preferred default by: https://maven.apache.org/plugins/maven-source-plugin/usage.html#installing-the-sources-along-with-your-artifact and prevents reruns of your generate sources phase such as graphql-simple-bindings, openapi generator and wirespec

Before:

❯ mvn  package  -DskipTests | egrep --line-buffered  ".*graphql.*---$"
mvnp='mvn package'
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-core ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-core ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-user ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-user ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-iso-country ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-iso-country ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-iso-language ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-iso-language ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-member ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-member ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-workspace ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-workspace ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-multi_tenant ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-multi_tenant ---

after

❯ mvn  package  -DskipTests | egrep --line-buffered  ".*graphql.*---$"
mvnp='mvn package'
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-core ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-user ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-iso-country ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-iso-language ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-member ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-workspace ---
[INFO] --- graphql-simple-bindings:0.8.0:generate (default) @ flock-eco-feature-multi_tenant ---


Preferred default by: https://maven.apache.org/plugins/maven-source-plugin/usage.html#installing-the-sources-along-with-your-artifact

and prevents reruns of your `generate sources` phase such as graphql-simple-bindings, openapi generator and wirespec
@ZzAve ZzAve merged commit 4b8680d into master Jan 21, 2024
3 checks passed
@ZzAve ZzAve deleted the fix-attach-sources-reruns branch January 21, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant