Build via Swift package manager #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelknoch
approved these changes
Mar 2, 2023
| @@ -0,0 +1,25 @@ | |||
| #if os(WASI) | |||
There was a problem hiding this comment.
nit: WASI shouldn't be needed for UIKit, right?
Sources/Logging.swift
Outdated
| import SDL | ||
|
|
||
| #if os(Android) | ||
| @_implementationOnly import SDL |
There was a problem hiding this comment.
I found some docs about this here but can you explain in our context what this actually changes?
Sources/UIScrollView+velocity.swift
Outdated
| @@ -34,7 +34,7 @@ extension UIScrollView { | |||
| let animationTimeConstant = 0.325 * dampingFactor | |||
|
|
|||
| // This calculation is a weird approximation but it's close enough for now... | |||
| let animationTime = log(Double(distanceToBoundsCheckedTarget.magnitude)) * animationTimeConstant | |||
| let animationTime = log2(Double(distanceToBoundsCheckedTarget.magnitude)) * animationTimeConstant | |||
| open class UIScrollView: UIView { | ||
| open weak var delegate: UIScrollViewDelegate? // TODO: change this to individually settable callbacks | ||
| open var panGestureRecognizer = UIPanGestureRecognizer() | ||
| open var panGestureRecognizer: UIPanGestureRecognizer |
There was a problem hiding this comment.
is it not possible anymore to init here in that line when using @mainactor?
|
|
||
| init { | ||
| arrayOf("JNI", "SDL", "UIKit").forEach { System.loadLibrary(it) } | ||
| } |
There was a problem hiding this comment.
do we use static linking already?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: DX, Performance
Motivation (current vs expected behavior)
Re-allow builds via SwiftPM, which should make it easier for others to integrate the library into their own builds. We also gain improved support for static linking, whole module optimization, etc. by doing this.
Please check if the PR fulfills these requirements