-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapper: add readdump message #439
base: main
Are you sure you want to change the base?
Conversation
To make up for breaking `read,dump` sequentiality
I'm thinking now about this, and I wonder what is the usecase that would not be fulfilled with reading the same file in parallel in a dict and in a FDS? |
You lose the convenient confirmation that the data has been loaded into the dataset to your satisfaction. Also, to gauge the extra faff, think about which repeated change you'd rather make to all the help file examples for the dataset related objects that use |
ah your convincing arguments :) obviously that will have to be done as part of this pr and it will be painful... another PR that will also need to happen is one in docs with the max_only flag, whatever its syntax, to explain this method and also add a line to read and write being deferred at the lowest rank of scoundrels... |
Help file updates is a simple regexp replace, although running the regexp reveals that there's only actually 5 instances where we do So maybe it's not worth it after all. |
I think that if it helps advanced users to avoid a loop to check status, it might be worth a road test. Let me see how the doc reacts... |
re the docs – documentation for |
Actually, I've just thought of an oversight in all this, which is to do with what gets spat out of the dump outlet after the message has completed. At the moment you'll get |
2 pragmatic options:
I'm opened to plan 3 - the ugly double message solution for now - to see how we freak on the nightlies... but that is a dangerous precedent :D |
It wouldn't make it easier, no. Or rather, it would introduce different difficulty. I'm minded not to bother with this for the time being. I thought we were relying much more heavily on |
ok I'll need to add a message in the doc and fix the helpfiles indeed with the deferlow merge, I'll do a PR for the discipline |
Ok, cheers. If you haven't already found them, help file bits to fix:
|
it is indeed... I'm drafting careful words for the docs now which will be of more consequence I think |
To make up for breaking
read,dump
sequentialityThis goes through the Max API to glue the two messages together, because otherwise there would have been disproportionately terrible template shenanigans