-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_node_exporter_metrics: Implement NVMe metrics #8049
Merged
edsiper
merged 1 commit into
master
from
cosmo0920-implement-nvme-metrics-on-node_exporter_metrics
Nov 7, 2023
Merged
in_node_exporter_metrics: Implement NVMe metrics #8049
edsiper
merged 1 commit into
master
from
cosmo0920-implement-nvme-metrics-on-node_exporter_metrics
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
cosmo0920-implement-nvme-metrics-on-node_exporter_metrics
branch
from
October 17, 2023 06:15
c7eb188
to
6070107
Compare
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
October 17, 2023 07:57
cosmo0920
force-pushed
the
cosmo0920-implement-nvme-metrics-on-node_exporter_metrics
branch
from
November 5, 2023 13:23
6070107
to
e728baf
Compare
I rebased off master. Hmm..., some of the unit tests for filter plugins are failed... |
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-implement-nvme-metrics-on-node_exporter_metrics
branch
from
November 6, 2023 18:06
e728baf
to
e56c0dc
Compare
edsiper
deleted the
cosmo0920-implement-nvme-metrics-on-node_exporter_metrics
branch
November 7, 2023 03:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the official Prometheus exporter, NVMe metrics is provided as a default collecting collector.
Then, we should provide it in fluent-bit. This is because non numerical metrics of NVMe is not collected other types of metrics on node_exporter_metrics.
Closes #7888
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
$ bin/fluent-bit -i node_exporter_metrics -p metrics=nvme -o stdout -v
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1235
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.