Revive old thrift and mark in_flume as obsoleted for Flume NG
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
reviewed
Oct 25, 2016
| @@ -32,8 +32,8 @@ class FlumeOutput < BufferedOutput | |||
|
|
|||
| def initialize | |||
| require 'thrift' | |||
| require 'fluent/plugin/thrift/flume_types' | |||
There was a problem hiding this comment.
Why is this require order changed?
There was a problem hiding this comment.
Curiously, this change prevents the following error in test:
E
=================================================================================================================================================================================================
Error: test_write(FlumeOutputTest): NameError: uninitialized constant Status
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/thrift/thrift_source_protocol.rb:88:in `<class:Append_result>'
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/thrift/thrift_source_protocol.rb:83:in `<module:ThriftSourceProtocol>'
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/thrift/thrift_source_protocol.rb:10:in `<top (required)>'
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/out_flume.rb:38:in `require'
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/out_flume.rb:38:in `initialize'
/Users/hhatake/Github/fluent-plugin-flume/vendor/bundle/ruby/2.3.0/gems/fluentd-0.12.20/lib/fluent/test/base.rb:44:in `new'
/Users/hhatake/Github/fluent-plugin-flume/vendor/bundle/ruby/2.3.0/gems/fluentd-0.12.20/lib/fluent/test/base.rb:44:in `initialize'
/Users/hhatake/Github/fluent-plugin-flume/vendor/bundle/ruby/2.3.0/gems/fluentd-0.12.20/lib/fluent/test/input_test.rb:28:in `initialize'
/Users/hhatake/Github/fluent-plugin-flume/vendor/bundle/ruby/2.3.0/gems/fluentd-0.12.20/lib/fluent/test/output_test.rb:51:in `initialize'
/Users/hhatake/Github/fluent-plugin-flume/test/plugin/test_out_flume.rb:16:in `new'
/Users/hhatake/Github/fluent-plugin-flume/test/plugin/test_out_flume.rb:16:in `create_driver'
/Users/hhatake/Github/fluent-plugin-flume/test/plugin/test_out_flume.rb:89:in `test_write'
86: def test_write
87: time = Time.parse("2011-12-21 13:14:15 UTC").to_i
88:
=> 89: d = create_driver
90: d.emit({"k11"=>"v11", "k12"=>"v12"}, time)
91: d.emit({"k21"=>"v21", "k22"=>"v22"}, time)
92: d.run
=================================================================================================================================================================================================
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10.
We should provide
in_flumefor Flume legacy users until 0.2.0 and display obsoleted message for Flume NG users.