Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target ruby versions #512

Closed
wants to merge 2 commits into from
Closed

Update target ruby versions #512

wants to merge 2 commits into from

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jul 29, 2024

Drop deprecated ruby version

* 3.0: EOL 2024-04-23
* 2.7: EOL 2023-03-31

ref. https://www.ruby-lang.org/en/downloads/branches/

Then add Ruby 3.3 for test matrix

kenhys added 2 commits July 29, 2024 15:41
@kenhys
Drop deprecated ruby version
2b5952c 
* 3.0: EOL 2024-04-23
* 2.7: EOL 2023-03-31

https://www.ruby-lang.org/en/downloads/branches/
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Add Ruby 3.3 for test matrix
9633957 
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

  • ruby 3.1 rdkafka >= 0.12 crashes, but it was not regression in this PR.
  • ruby 3.2 rdkafka >= 0.12 also crashes, but undefined method 'close' is same as before.

@kenhys kenhys requested a review from daipom July 29, 2024 08:15
@kenhys kenhys marked this pull request as draft July 29, 2024 08:35
@kenhys
Copy link
Contributor Author

kenhys commented Jul 29, 2024

Fluentd still enables ruby 2.7 CI.

@kenhys kenhys removed the request for review from daipom July 29, 2024 08:36
@kenhys kenhys added the pending Need to be fixed in upstream(ruby-kafka) or something label Jul 29, 2024
@kenhys kenhys closed this Jul 30, 2024
@kenhys kenhys deleted the drop-ruby27 branch July 30, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending Need to be fixed in upstream(ruby-kafka) or something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kenhys