Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sts_http_proxy and sts_endpoint_url to web_identity_credentials #452

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

rubroboletus
Copy link
Contributor

possibly solves #451

@daipom
Copy link
Contributor

daipom commented Jan 27, 2025

@daipom
Copy link
Contributor

daipom commented Jan 27, 2025

@rubroboletus Thanks for this enhancement!!
So, this PR adds the same options to web_identity_credentials as assume_role_credentials.
It looks good to me.

If you can, could you please add a note to the next document about these options?

Since there is no description of these existing options in assume_role_credentials, it would be helpful if you could add a description for both assume_role_credentials and web_identity_credentials.

@rubroboletus rubroboletus force-pushed the sts_endpoint_for_web_identity branch from 102e42e to 40b18aa Compare January 28, 2025 06:53
@rubroboletus
Copy link
Contributor Author

@rubroboletus
Copy link
Contributor Author

@rubroboletus Thanks for this enhancement!! So, this PR adds the same options to web_identity_credentials as assume_role_credentials. It looks good to me.

If you can, could you please add a note to the next document about these options?

Since there is no description of these existing options in assume_role_credentials, it would be helpful if you could add a description for both assume_role_credentials and web_identity_credentials.

Sorry, but I'm not a right one person for this task. My english is on very basic level.

@daipom daipom merged commit 1204570 into fluent:master Jan 29, 2025
5 checks passed
@daipom
Copy link
Contributor

daipom commented Jan 29, 2025

Thanks for this enhancement!

@daipom daipom linked an issue Jan 29, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow set http proxy and sts_endpoint_url for web_identity_credentials
2 participants