some refactoring #34
Open
some refactoring #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luaL_checkint is available only in Lua 5.1 & 5.2 luaL_checkinteger is available in Lua 5.1, 5.2, 5.3 & 5.4 fix flukso#32
only used here
karlp
reviewed
Jun 2, 2022
lua-mosquitto.c
Outdated
|
|
||
| lua_pushliteral (L, "Lua bindings to libmosquitto"); | ||
| lua_setfield (L, -2, "_DESCRIPTION"); | ||
| lua_pushliteral (L, "0.4.1"); |
There was a problem hiding this comment.
not like this, this would have to be something that is done automatically, so it doesn't have to be edited and committed on every release, that's too manual. general idea sounds fine though :)
There was a problem hiding this comment.
it was the last commit of the serie.
so, I remove it
|
The rest of this seems fine I guess |
|
Just fair warning, I'm not going to merge any of this set (myself at least) until I'm working on other stuff here, so this could wait a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.