Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add myLocationStyle #985

Closed
wants to merge 1 commit into from
Closed

feat: Add myLocationStyle #985

wants to merge 1 commit into from

Conversation

robert-go
Copy link

@robert-go robert-go commented Mar 31, 2022 •
edited
Loading

@felix-ht
Copy link
Collaborator

please also run formatting

 java \  
  --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
  -jar google-java-format-1.13.0-all-deps.jar -i $(find . -type f -name "*.java")

swiftformat --swiftversion 4.2 --maxwidth 100 ios

@robert-go robert-go force-pushed the feat/my-location-style branch from 53db7df to d7fa581 Compare April 1, 2022 03:19
@robert-go robert-go force-pushed the feat/my-location-style branch from d7fa581 to 1500fc1 Compare April 1, 2022 03:22
robert-go
robert-go commented Apr 1, 2022
View reviewed changes
ios/Classes/MapboxMapController.swift
if let pulsingColor = UIColor(hexString: style["pulsingColor"] ?? "") {
userLocationAnnotationViewStyle.haloFillColor = pulsingColor
}
mapView.updateUserLocationAnnotationView()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felix-ht can you take a look?
mapView.updateUserLocationAnnotationView() cannot help refresh new color after setState or hot reload

android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
@Override
public void setMyLocationStyle(Map myLocationStyle) {
this.myLocationStyle = myLocationStyle;
updateLocationComponentLayer();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felix-ht can you take a look?
updateLocationComponentLayer() cannot refresh new color after setState or hot reload

@StephenHodgson
Copy link

@felix-ht any update on this?

@stale
Copy link

stale bot commented Jun 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 21, 2022
@stale stale bot closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-ht felix-ht felix-ht requested changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-go @felix-ht @StephenHodgson