Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace string enum usage with dart enums #479

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

replace string enum usage with dart enums #479

wants to merge 3 commits into from

Conversation

victortive
Copy link
Contributor

  • Usage of strings for the direction is confusing and inconsistent as one place uppercased the call direction.
  • To make the API easier to use, I have replaced the direction with an enum

@victortive victortive marked this pull request as draft September 26, 2024 21:47
@victortive victortive marked this pull request as ready for review September 26, 2024 22:29
@victortive victortive changed the title replace usage of direction as a string with an CallDirection enum replace string enum usage with dart enums Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victortive @VictorUvarov