Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera] Remove OCMock from CameraSettingsTests, CameraMethodChannelTests and CameraSessionPresetsTests #8592

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

mchudy
Copy link
Contributor

@mchudy mchudy commented Feb 8, 2025

Continuation of OCMock removal from tests related to flutter/flutter#119109.

  • Introduces new protocols: FLTFrameRateRange and FLTCaptureDeviceFormat
  • Refactors CameraTestUtils to get rid of multiple similar helper methods in favor of using FLTCamConfiguration to set up mocks in tests. Also removes some OCMock usage from there.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@mchudy mchudy requested a review from stuartmorgan February 10, 2025 08:14
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(That was meant to be an actual LGTM approval.)

@mchudy mchudy added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2025
@auto-submit auto-submit bot merged commit 0566371 into flutter:main Feb 10, 2025
82 checks passed
@mchudy mchudy deleted the feature/camera-ocmock-part5 branch February 10, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-ios platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants