-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed pop the wrong page when changing the speed #871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than this nit, everything else looks good for this PR.
@akmalova Are you still actively working on this PR? |
Done |
@akmalova Please run |
Lastly, please re-sync your changes with |
@akmalova you still with us on this PR? |
@diegotori Yes, I'm sorry, I didn't have time. I've fixed everything now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #871 +/- ##
==========================================
- Coverage 45.26% 44.91% -0.35%
==========================================
Files 22 22
Lines 1542 1545 +3
==========================================
- Hits 698 694 -4
- Misses 844 851 +7 ☔ View full report in Codecov by Sentry. |
Fixed pop the wrong page when changing the speed
Issue: #618
This was during the speed change and the use of additional options. This was due to the use of the wrong context. In order for the bottom sheet to close correctly, we need to use the context of the bottom sheet itself.
In this regard, I had to add the
BuildContext context
parameter to theOptionItem
model inonTap
callback. Now there is no such problem.Function(BuildContext context)? onTap;
Such a bug was noticed in a project where we use AutoRoute package, so maybe this bug has something to do with using this package.