shell: fix signal plugin to work with Fluxion scheduler #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The shell signal plugin doesn't work with Fluxion because it expects a float value for expiration in R and Fluxion encodes an integer. Update the format specifier in the signal plugin's use of json_unpack on R to use `s:F` instead of `s:f` so that the plugin works with Fluxion. Fixes flux-framework#6521
|
Restarted the alpine builder which failed with an unrelated failure in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The shell signal plugin doesn't work with Fluxion because it expects a float value for expiration in R and Fluxion encodes an integer.
Update the format specifier in the signal plugin's use of json_unpack on R to use
s:Finstead ofs:fso that the plugin works with Fluxion.Fixes #6521