fix possible truncation of strings with "expandable" output fields #6533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A test in t/python/t0024-util.py doesn't specify the 'f' format type so OutputFormat will adjust width and precision as a string, which the test does not expect. Fix the test to use the 'f' presentation type.
Problem: The `+:` sentinel which expands width of fields doesn't adjust
precision as well, which ends up truncating strings in a field that
has been expanded to fit the largest value.
The set of matching types needs to be expanded from ("s", None)
to include the empty string to handle the case where a presentation
type is not specified, so string is assumed.
Add "" to the set of types for which to adjust precision.
Fixes flux-framework#6530
Problem: No test in the testsuite ensures that the OutputFormat class adjusts precision for string presentation types if the width is adjusted due to the `+:` sentinel. Add a test that ensures correct handling of precision.
|
Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6533 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 522 522
Lines 87860 87860
=======================================
+ Hits 73479 73482 +3
+ Misses 14381 14378 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes truncation of strings in output formats that use the
+:sentinel, when the field width is greater than the minimum precision (e.g.+:{field:10.10}and the maximum width > 10)