kvs: add transaction stats #6556
Open
+105
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, looks like our CI doesn't have Edit: agh ... try again. CI didn't like my use of single quotes. |
chu11
force-pushed
the
kvs_txn_stats
branch
4 times, most recently
from
f7e9efd to
4506ffa
Compare
Problem: In the future we would like to put a cap on the maximum number of operations in a transaction. However, we do not have any stat tracking of operations in a transaction. Add transaction stats for commits and fences in the kvs module.
Problem: The testing of stats clearing in the KVS is done a little bit before the end of a set of tests. This can be inconvenient for future tests that do not wish stats to be cleared. Move the clearing of stats tests towards the end of tests in t1001-kvs-internals.t.
Problem: There is no coverage for the new KVS transaction stats. Add coverage in t1001-kvs-internals.t.
|
oops, i totally forgot about stats clearing. Tweaked and added a test. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6556 +/- ##
==========================================
- Coverage 79.44% 79.42% -0.02%
==========================================
Files 531 531
Lines 88247 88269 +22
==========================================
+ Hits 70110 70112 +2
- Misses 18137 18157 +20
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In the future we would like to put a cap on the maximum number
of operations in a transaction. However, we do not have any stat tracking
of operations in a transaction.
Add transaction stats for commits and fences in the kvs module.
This is really a "prep" for #6125. I decided to split out the stats for commits & fences, since they are quite different. For example, if every process in an job did a fenced KVS transaction with a single op, this scales up with the size of cluster. So we want to count that differently than each op individually.
Note that I could have done "stats per namespace", but that wasn't really the information that we want. We mostly want to know what is the average and what is the max. So I did it "globally" vs per namespace.