Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjobspec: ensure task count has exactly one key #1343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sam-maloney
Copy link

Problem: the desired number of tasks is ambiguous if more than one key is set in tasks.count

Fail with an error message if multiple keys are found in the jobspec

This is based on the proposed amendment to RFC 14 in flux-framework/rfc#441

Problem: the desired number of tasks is ambiguous if more than one key
is set in tasks.count

Fail with an error message if multiple keys are found in the jobspec
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.7%. Comparing base (da6156a) to head (992bc9c).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1343   +/-   ##
======================================
  Coverage    75.7%   75.7%           
======================================
  Files         112     112           
  Lines       16410   16412    +2     
======================================
+ Hits        12426   12428    +2     
  Misses       3984    3984           
Files with missing lines Coverage Δ
resource/libjobspec/jobspec.cpp 87.0% <100.0%> (+<0.1%) ⬆️

@trws trws self-requested a review February 19, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant