Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fadec rewrite using Cpp framework #8547

Merged
merged 80 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
abef37e
Initial scaffolding for new fadec
frankkopp Mar 2, 2024
16de802
Added SIMULATION RATE to base data
frankkopp Mar 2, 2024
a4b274a
Added SIM ON GROUND to base data
frankkopp Mar 2, 2024
5197376
Initial scaffolding for new EngineControl
frankkopp Mar 2, 2024
d9c524f
Initial scaffolding for both aircraft
frankkopp Mar 2, 2024
fd4206b
Remove build code for old fadec
frankkopp Mar 2, 2024
fdc4ee6
migrated the common.h code to Fadec.h
frankkopp Mar 2, 2024
56046fe
removed simulation time params
frankkopp Mar 2, 2024
6d370d3
inlined var init
frankkopp Mar 2, 2024
f77bbe0
Code cleanup and documentation
frankkopp Mar 3, 2024
755e863
Renaming of context var
frankkopp Mar 3, 2024
3f3cc78
Added ThrustLimit_A380X class and helper methods in Fadec.h
frankkopp Mar 2, 2024
8b842a3
Improved insertThousandsSeparator helper
frankkopp Mar 3, 2024
b62e8d0
Merge fix
frankkopp Mar 3, 2024
f015100
Commenting ThrustLimits_A380X.h
frankkopp Mar 3, 2024
ba7d40c
Commenting SimDataStructs.h
frankkopp Mar 3, 2024
3806ed8
Adding Polynomials_A380X.hpp
frankkopp Mar 4, 2024
4591e97
Adding Table1502_A380X.hpp
frankkopp Mar 4, 2024
009953b
Adding Table1502_A380X.hpp
frankkopp Mar 4, 2024
1c115ad
Adding some commenting to framework classes
frankkopp Mar 4, 2024
20f3e9a
Adding FuelConfiguration class
frankkopp Mar 4, 2024
e6b544a
Added TODO
frankkopp Mar 4, 2024
2f06990
Import fix
frankkopp Mar 4, 2024
e407513
code style fix
frankkopp Mar 4, 2024
e9042cb
Renamed Class
frankkopp Mar 4, 2024
f3e7af0
changed class access and fixed migrated code
frankkopp Mar 4, 2024
1e64c87
Added FadecSimData class and implemented initialization of EngineControl
frankkopp Mar 4, 2024
d2eb553
Added EngineControl_A380X.cpp update()
frankkopp Mar 5, 2024
6bf3d34
Adding some commenting to framework class
frankkopp Mar 5, 2024
4ee09f2
Implemented additional update functions
frankkopp Mar 5, 2024
aa3d063
Implemented all required functions
frankkopp Mar 6, 2024
4ca8103
Checked initialize
frankkopp Mar 6, 2024
6e241bf
Checked update
frankkopp Mar 6, 2024
27ddb8c
Bug fix setting feed tanks
frankkopp Mar 7, 2024
cb4f085
Fix unit for EGT
frankkopp Mar 7, 2024
bd0b97c
Refactored var access
frankkopp Mar 7, 2024
3e269dc
Added profiler
frankkopp Mar 7, 2024
4eef195
Added more profiler
frankkopp Mar 7, 2024
6fef639
Refactored writing and added gauge profiler
frankkopp Mar 7, 2024
4a75390
added "using DataDefinitionVector"
frankkopp Mar 9, 2024
f12636a
Prepared A32NX fadec migration (wip)
frankkopp Mar 9, 2024
d72df0b
Improved Pause detection (removed unnecessary read)
frankkopp Mar 8, 2024
b65c062
Additional profiler when PROFILING is set
frankkopp Mar 8, 2024
b8c8803
Added usage commenting to SimpleProfiler
frankkopp Mar 8, 2024
75768f4
Added default flag to set data on Sim Object
frankkopp Mar 8, 2024
e4af7b1
Added a flag to turn on/off warning of dirty data read.
frankkopp Mar 8, 2024
e9a40a6
Minor docu fix in AircraftVariable.h
frankkopp Mar 8, 2024
f140588
Prepared A32NX fadec migration (wip)
frankkopp Mar 9, 2024
ddedff9
Fixed reading of initial pause var
frankkopp Mar 9, 2024
7c98574
Added fuel config and data definitions
frankkopp Mar 9, 2024
3459ab0
Added ThrustLimits_A32NX.hpp
frankkopp Mar 9, 2024
d3abf8a
Added Polynomials_A32NX.hpp
frankkopp Mar 9, 2024
d08f8f3
Added Tables1502_A32NX.hpp
frankkopp Mar 9, 2024
22b11e7
Fixed to_string_with_zero_padding by making static
frankkopp Mar 9, 2024
a986fd5
Added initializeEngineControlData
frankkopp Mar 10, 2024
6dcb922
Added comment
frankkopp Mar 10, 2024
123df30
Added Gph (Gallons per hour) to UNITS
frankkopp Mar 11, 2024
e087e7c
Added profiler metadata output
frankkopp Mar 12, 2024
e9fbb72
Migration done - debugging wip
frankkopp Mar 12, 2024
7b37504
Commenting FuelConfiguration_A32NX.h
frankkopp Mar 17, 2024
9ace8e4
Commenting and cleanup
frankkopp Mar 17, 2024
ca8ea5a
Commenting, cleanup and removed a recursion
frankkopp Mar 17, 2024
711c6bd
Commenting
frankkopp Mar 17, 2024
cc67cbf
Added EngineRatios class
frankkopp Mar 17, 2024
10dba5a
Migration done - debugging wip
frankkopp Mar 17, 2024
56458cd
Fixed engine startup - code working so far
frankkopp Mar 18, 2024
d1a9963
Moved read only Aircraft Variables to DataDefinition for 50% performa…
frankkopp Mar 18, 2024
d40d768
Further cleanup
frankkopp Mar 18, 2024
196df19
Undo change in logic for fuel used
frankkopp Mar 18, 2024
adf043f
Migration A380X done - debugging & testing
frankkopp Mar 19, 2024
90a2028
Cleanup and commenting
frankkopp Mar 19, 2024
51dba35
Fixed fuel issue on A380X
frankkopp Mar 20, 2024
e0650ed
Cleanup and commenting
frankkopp Mar 21, 2024
0b13bec
Removed previous fadec code
frankkopp Mar 21, 2024
07760fd
Cleanup and commenting
frankkopp Mar 21, 2024
c3ad17a
Reversed tank order of flyPad Fuel Page
frankkopp Mar 22, 2024
f4881cc
Cleanup and commenting
frankkopp Mar 22, 2024
cffba49
Fix LVar resetting
frankkopp Mar 24, 2024
f9123ab
Review changes
frankkopp Mar 27, 2024
f3f78fd
Added CHANGELOG.md entry
frankkopp Apr 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
1. [FWC] Implement non-cancellable master warning for overspeed and gear not down - @tracernz (Mike)
1. [EFB] Checklist restructure to add more capabilities and use json configs - @frankkopp (Frank Kopp)
1. [FLIGHTMODEL] Landing lights or RAT extended now have drag - @Crocket63 (crocket)
1. [FADEC] Fadec rewrite/cleanup/commenting using cpp framework - @frankkopp (Frank Kopp)

## 0.11.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ background_color = 0,0,0

htmlgauge00 = WasmInstrument/WasmInstrument.html?wasm_module=systems.wasm&wasm_gauge=systems,0,0,1,1
htmlgauge01 = WasmInstrument/WasmInstrument.html?wasm_module=fbw.wasm&wasm_gauge=fbw,0,0,1,1
htmlgauge02 = WasmInstrument/WasmInstrument.html?wasm_module=fadec.wasm&wasm_gauge=FadecGauge,0,0,1,1
htmlgauge02 = WasmInstrument/WasmInstrument.html?wasm_module=fadec-a32nx.wasm&wasm_gauge=Gauge_Fadec,0,0,1,1
htmlgauge03 = WasmInstrument/WasmInstrument.html?wasm_module=extra-backend-a32nx.wasm&wasm_gauge=Gauge_Extra_Backend,0,0,1,1

[VCockpit18]
Expand Down
5 changes: 3 additions & 2 deletions fbw-a32nx/src/wasm/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ set(OUTPUT_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../out/flybywire-aircraft-a3
add_definitions(-DA32NX)

add_subdirectory(extra-backend-a32nx)
add_subdirectory(fadec_a32nx)

# FIXME: remove the if-clause as soon as all components are using CMake
# these are only here to allow CMake compatible IDEs (JetBrains' Clion for example) to show systax
# highlighting and allow code navigation
if (WIN32)
add_subdirectory(fadec_a320)
add_subdirectory(fbw_a320)
endif ()
26 changes: 0 additions & 26 deletions fbw-a32nx/src/wasm/fadec_a320/CMakeLists.txt

This file was deleted.

9 changes: 0 additions & 9 deletions fbw-a32nx/src/wasm/fadec_a320/README.md

This file was deleted.

75 changes: 0 additions & 75 deletions fbw-a32nx/src/wasm/fadec_a320/build.sh

This file was deleted.

Loading