feat(a380/mfd): position monitor page #9182
Draft
+578
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wohoo, Bruno's been cooking again |
becas22
changed the title
BravoMike99
force-pushed
the
380-mfd-pos-monitor
branch
2 times, most recently
from
7d0e01e to
a6caf23
Compare
tracernz
reviewed
Nov 2, 2024
| @@ -198,14 +198,34 @@ export class Navigation implements NavigationProvider { | |||
| NearbyFacilities.getInstance().setPpos(this.ppos); | |||
| } | |||
|
|
|||
| public updateRnp(rnp: number | null) { | |||
There was a problem hiding this comment.
Suggested change
| public updateRnp(rnp: number | null) { | |
| public setPilotRnp(rnp: number | null) { |
Don't want confusion around this, hence the original naming.
| return this.currentPerformance ?? Infinity; | ||
| } | ||
|
|
||
| public getRnp(): NauticalMiles { |
There was a problem hiding this comment.
Suggested change
| public getRnp(): NauticalMiles { | |
| /** | |
| * Gets the active RNP considering priority order. | |
| * @returns RNP in nautical miles, or undefined if none. | |
| */ | |
| public getActiveRnp(): number | undefined { |
| public getBaroCorrectedAltitude(): number | null { | ||
| return this.baroAltitude; | ||
| } | ||
|
|
||
| public getEpe(): number { | ||
| public getEpe(): NauticalMiles { |
There was a problem hiding this comment.
These types that are just = number are legacy. Better to document the API properly.
Suggested change
| public getEpe(): NauticalMiles { | |
| /** | |
| * Gets the estimated position error. | |
| * @returns Estimated position error in nautical miles, or Infinity if no position. | |
| */ | |
| public getEpe(): number { |
| /** | ||
| * Get if a manual RNP entry was performed | ||
| */ | ||
| isRnpManual(): boolean; |
There was a problem hiding this comment.
Update the interface per above suggestions.
Comment on lines
+59
to
+65
| get positionMonitorFix(): Fix | null; | ||
|
|
||
| set positionMonitorFix(fix: Fix | null); |
There was a problem hiding this comment.
Suggested change
| get positionMonitorFix(): Fix | null; | |
| set positionMonitorFix(fix: Fix | null); | |
| positionMonitorFix: Fix | null; |
Comment on lines
131
to
137
| get positionMonitorFix(): Fix | null { | ||
| return this.posMonitorFix; | ||
| } | ||
|
|
||
| set positionMonitorFix(fix: Fix | null) { | ||
| this.posMonitorFix = fix; | ||
| } |
There was a problem hiding this comment.
Trivial getter/setter doesn't do anything except harm perf.
BravoMike99
force-pushed
the
380-mfd-pos-monitor
branch
from
c0130d9 to
971b512
Compare
BravoMike99
force-pushed
the
380-mfd-pos-monitor
branch
2 times, most recently
from
d251402 to
1d8df34
Compare
BravoMike99
force-pushed
the
380-mfd-pos-monitor
branch
from
1d8df34 to
6a2c2b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
bruno_pt99
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.