-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/flight model): A380X Flight Model Update plus fix auto-rotate issue #9728
base: master
Are you sure you want to change the base?
Conversation
@donstim If tested this PR when you opened it 1 or 2 week ago, so it might be a bit outdated but I wanted to give feedback. The auto rotation works really good and only at light weight It rotated a few knots before the actual rotate speed. This works really well. The flap modification didn’t work that good. Flap config 1 and 2 worked pretty much as before but on landing when deploying flap cfg 3 and then Full the aircraft generates from on moment to another so much lift that it needed to pitch down so drastically that you went from a normal (-1)° - 3°pitch, with Flap cfg 1 or 2, on an 3° glide-slope TO an 5° or more nose down dive to stay on this 3° glide-slope with cfg 3 and Full. What I want to say by that is that In my opinion Flaps cfg 3 and Full produced way to much lift, keep in mind that this might be fix until now. Maybe this feedback helps even though it’s 2 weeks old. |
Thanks for the comments, but yes the version you tested is very much outdated. I continue to work with this on my own system and only occasionally update this PR. Even so, I don't think I've ever had the behavior you've described for CONF 3 and FULL. I've chosen a more critical case for the auto rotate issue and have resolved it, but it requires an unacceptably high trim level during other phases of flight. Still working on it, but it's a very frustrating process that requires constant re-tuning of parameters every time one of the major parameters is changed. |
Hi, I just did a flight taking off at 430T with a 55c Flex, 132, 147, 152. In terms of the BTV, everything was fine. I did not catch anything odd. Thank you for this fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving an approval for QA flow to start
@donstim Hey, I tested three scenarios: medium, no load, and extra-long haul load. Everything looks good so far. Are there any specific or additional scenarios you would like me to test before I submit my report? Thanks! |
No, that sounds great. Thank you! |
Quality Assurance Trainee Report Discord Username : utkrishtm Testing Process:
Testing Results: Negatives:
Conclusions:
Media:
|
I know 2024 is not supported, but I am commenting just for tracking. It is really wierd, because with this exact build in 2020, nothing like that happens. |
Thanks for the thorough test. Thsi PR only affexts the flight model, so it can't cause the issues you had with OANS. Regarding staying within the operating limitations like weight, cg, speed, etc., just like the real airplane, complying with those limitations is the responsibility of the pilot/operator. The real airplane can also be overloaded. I'm out of town and cannot see your videos well enough on my small phone to see what you're describing. If you're talking about pitch being more sensitive in CONF 2 than CONF 1+F during takeoff rotation such that the same input leads to higher than intended pitch angles, adjusting that will have to wait until the rotation law can be tuned. In any case, you should be able to pitch up to the highest pitch attitude attainable without being able to recover without stalling uncontrollably. |
Thanks for the report. One more reason I guess not to use FS2024. Must be due to one of those completely undocumented flight model "improvements" people keep talking about where the same input parameters for 2020 lead to different results in 2024. Pretty hard to develop an airplane that way. |
@donstim could you again merge the master in your PR request that its up.-to-date again. that would be great, thank you |
Sorry, I am out of town for the next week. The web editor to resolve the conflicts on the changelog page does not well on my phone. Anyone should be able to do it. |
Done 👍 |
Fixes #[issue_no]
Summary of Changes
General update to flight model plus:
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): donbikes
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.