Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380/nd): Fixed TCAS message position and add TCAS STBY #9789

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MrJigs7
Copy link
Contributor

@MrJigs7 MrJigs7 commented Jan 20, 2025

Fixes #9054

Summary of Changes

Updated logic on dynamic class for TCAS messages
Added class to adjust text position for A380 TCAS Messages
Added TCAS STBY display
Added class to hide in A32NX

Screenshots (if necessary)

TCASFail
TcasFail2
TCASStby
TCASTAOnly

References

TCASFailRef
TCASStbyRef
TCASTAOnlyRef

Other video references on issue #9054

Additional context

I've added the TCAS STBY in using CSS classes but if the preference would be to do it via a prop I can change it

Discord username (if different from GitHub):MrJigs.

Testing instructions

  1. Start A380X cold and dark
  2. Power aircraft, align IRS and enable XPDR
  3. Check TCAS STBY flag shown as initial message
  4. Check through various TCAS modes and correct flag is shown on ND with correct positioning
  5. Fail TCAS and check flag is shown on ND with correct positioning
  6. Load A32NX and observe no changes

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@MrJigs7 MrJigs7 changed the title Fix(a380/nd): Fixed TCAS message position and add TCAS STBY fix(a380/nd): Fixed TCAS message position and add TCAS STBY Jan 20, 2025
@tracernz
Copy link
Member

tracernz commented Jan 20, 2025

We should think about whether it makes sense for these messages to actually just be part of the aircraft rather than the fbw-common part of the ND, as they differ in many ways (more than now when fully realised), and having them in fbw-common makes it harder to fix them up to use the proper ARINC429 words in the A32NX and AFDX in the A380X for example. I think those things outweigh duplication of some trivial code, and it ends up tidier than these CSS classes.

@MrJigs7 MrJigs7 requested a review from tracernz January 22, 2025 11:23
@MrJigs7
Copy link
Contributor Author

MrJigs7 commented Jan 22, 2025

Made requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

A380X/ND: ND TCAS messages not centered
2 participants