-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/fms): Vapp wind correction #9809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! To make it more accurate, could you please
- Always add 5kts for manual A/THR on landing technique (which is what we should assume for now), and
- Remove the minimum wind component of 5 kts from
addWindComponent
?
Seems to be slightly different from the A320, where the wind correction is between 5 and 15 kts. On the A380 with A/THR on and 45kts headwind, it seems it can be VLS+20 (if I interpret my references correctly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: Sorry for the confusion, I looked in the OIT calculations instead of the flight envelope part. Your implementation is correct, I'll approve it. Since it's such a small change, we don't need QA.
@Waveif Before merging, could you please add a changelog entry? |
Sure thing |
Thanks! Merging now. |
Fixes #9333
Summary of Changes
Fixed an issue where vapp was taking the full headwind factor instead of 1/3 of the steady headwind.
Screenshots (if necessary)
Before:
![image](https://private-user-images.githubusercontent.com/82508269/407423981-f763c5c8-697b-43fe-b04d-b67c77286da2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3OTE4MzQsIm5iZiI6MTczODc5MTUzNCwicGF0aCI6Ii84MjUwODI2OS80MDc0MjM5ODEtZjc2M2M1YzgtNjk3Yi00M2ZlLWIwNGQtYjY3Yzc3Mjg2ZGEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDIxMzg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQyNDgwNjA2MThkOTkxOTM2MzlhOWNlNWJkNjFjYWNhYzZlZTIyMGYyNjE3NTM2ZGNlMmZiNDYxZjQ3ZGI1ZTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wFWaJGP3nyjDPAVUaYKqHVEuJ1OKQjEwdJsifxYNhF4)
After:
![image](https://private-user-images.githubusercontent.com/82508269/407422371-3c872710-0546-4bd5-8b18-623f08f61aa4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3OTE4MzQsIm5iZiI6MTczODc5MTUzNCwicGF0aCI6Ii84MjUwODI2OS80MDc0MjIzNzEtM2M4NzI3MTAtMDU0Ni00YmQ1LThiMTgtNjIzZjA4ZjYxYWE0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA1VDIxMzg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRjOTljMmZlZTY0N2RlYjNmMjNjMWI4MjAwYzg4OWI5NmUyNTFiOWE4ZGQyZmU4ZmMxM2I2MzFkN2Q0M2IyODUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ym6V5-KCJaW43KBKTJvvbCnrEn65KALqSsK98C38uvU)
References
Reference image is linked in the issue #9333
Additional context
Discord username (if different from GitHub):
waveif
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.