-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(a32nx): port legacy fms/mcdu to typescript #9823
refactor(a32nx): port legacy fms/mcdu to typescript #9823
Conversation
fbw-a32nx/src/systems/instruments/src/MCDU/McduFsInstrument.tsx
Outdated
Show resolved
Hide resolved
fbw-a32nx/src/systems/instruments/src/MCDU/McduFsInstrument.tsx
Outdated
Show resolved
Hide resolved
...typings/flybywire-vcockpits-instruments/html_ui/Pages/VCockpit/Instruments/A32NX/legacy.d.ts
Outdated
Show resolved
Hide resolved
Unfortunately that means you have to copy everything.. we should consider renaming index.ts to index-react.ts, and index-no-react.ts to index.ts.
It does the right thing much more often than any of the other options. Some of our messed up tsconfig paths can still trick it though. Those also cause barrel imports from inside the same "project" => circular refs.
fdc31c9
to
ab9b541
Compare
Fixing this old logic caused it to work now, and find actual issues. We should handle more gracefully though and redirect the message to the queue.
Thanks. Possibly missed something when rebasing after the fix info merge. |
Fixed. Some or all of this is broken on master too; now fixed here. |
Quality Assurance Tester/Trainee Report Discord Username : Heclak Testing Process: Testing Results: Conclusions: Media: |
…fe-for-human-consumption
I've completed a few flights, and drilled into a lot of spots I'd normally never or rarely go in the MCDU to try some things out. I fixed a small bug with the NAV RADIO page not re-drawing after tuning an ILS, but otherwise all seems good. I'll merge it, and address anything that comes up in the next few days, as no doubt people will think of things we will never think to test. |
Fixes #[issue_no]
Summary of Changes
The "refactor" commits are adding/changing/fixing types, while the "fix" commits are fixing actual bugs found through adding types.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Perform full flights primarily in A32NX, but also smoke test A380X due to FMS commonality. Test CLOSEST AIRPORTS page in the A32NX (under DATA page), as it's been rewritten.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.