Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(a32nx): port legacy fms/mcdu to typescript #9823

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Feb 1, 2025

Fixes #[issue_no]

Summary of Changes

The "refactor" commits are adding/changing/fixing types, while the "fix" commits are fixing actual bugs found through adding types.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Perform full flights primarily in A32NX, but also smoke test A380X due to FMS commonality. Test CLOSEST AIRPORTS page in the A32NX (under DATA page), as it's been rewritten.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz tracernz added QA Tier 2 A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft labels Feb 1, 2025
@tracernz tracernz added this to the v0.13.0 milestone Feb 1, 2025
@tracernz tracernz force-pushed the mrc-raw-js-not-safe-for-human-consumption branch from fdc31c9 to ab9b541 Compare February 2, 2025 00:31
@tracernz tracernz requested a review from Benjozork February 2, 2025 00:32
Fixing this old logic caused it to work now, and find actual issues. We should handle more gracefully though and redirect the message to the queue.
@heclak
Copy link
Contributor

heclak commented Feb 2, 2025

still in progress with a flight but I found an issue with the fix info page.

MSFS2024 SU1 Beta
A32NX

Repro steps:

  1. Go to fix info page
  2. Enter a fix name into 1L LSK. Page changes to the one shown below. I can press CLR and 1L LSK to "delete" the fix name and return to the blank fix info page.

image

@tracernz
Copy link
Member Author

tracernz commented Feb 2, 2025

Thanks. Possibly missed something when rebasing after the fix info merge.

@tracernz
Copy link
Member Author

tracernz commented Feb 2, 2025

Fixed. Some or all of this is broken on master too; now fixed here.

@heclak
Copy link
Contributor

heclak commented Feb 3, 2025

Quality Assurance Tester/Trainee Report

Discord Username : Heclak
Object of testing : #9823
Aircraft : A32NX
Tier of Testing : 2
Date : 03/02/2025

Testing Process:
Did a full flight from SBSP to SBRJ. Used the standard MCDU pages and clicked through the other pages to check for broken pages.

Testing Results:
Passed

Conclusions:
No broken pages were observed. Checked closest airports page and it looked fine. Fix info page is now working correctly.

Media:

image

@tracernz
Copy link
Member Author

tracernz commented Feb 4, 2025

I've completed a few flights, and drilled into a lot of spots I'd normally never or rarely go in the MCDU to try some things out. I fixed a small bug with the NAV RADIO page not re-drawing after tuning an ILS, but otherwise all seems good. I'll merge it, and address anything that comes up in the next few days, as no doubt people will think of things we will never think to test.

Playing with CLOSEST AIRPORTS while in cruise:
image
image

@tracernz tracernz merged commit 082cf1b into flybywiresim:master Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft QA Passed QA Tier 2
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants