feat(a32nx/mcdu): H4 ground & cruise temperature sign improvement #9827
+16
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const temp = parseInt(tempString.replace('M', '-')); | ||
| console.log('tS: ' + tempString); | ||
| console.log('ti: ' + temp); | ||
| let temp = parseInt(tempString); |
There was a problem hiding this comment.
Is it intended that you can no longer type in a negative value in the format of "M03" for example?
There was a problem hiding this comment.
Yep. No manual mentions the M thing and it is oddly specific to this field hence why I removed it.
tracernz
reviewed
Feb 5, 2025
| @@ -785,4 +789,8 @@ export class CDUInitPage { | |||
| static formatWindComponent(tailwindComponent) { | |||
| return Math.round(Math.abs(tailwindComponent)).toFixed(0).padStart(3, '0'); | |||
| } | |||
|
|
|||
| static formatTemperature(temperature: number): string { | |||
| return (temperature > 0 ? '+' : '') + temperature.toFixed(0) + '°'; | |||
There was a problem hiding this comment.
Suggested change
| return (temperature > 0 ? '+' : '') + temperature.toFixed(0) + '°'; | |
| return `${temperature > 0 ? '+' : ''}${temperature.toFixed(0)}°`; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Continuing the H4 PR train, changes temperature display on the INIT page of the GND TEMP & CRZ TEMP fields to show a sign if the value is not zero.
Cruise temperature entry assumes a negative value if no sign is entered.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
bruno_pt99
Testing instructions
Open the init page of the MCDU.
Verify GND TEMP value shows a positive sign if the value is positive.
Enter a negative value, verify negative sign is shown.
Enter a value of 0, verify no sign is shown.
On the CRZ FL/TEMP prompt, enter the temperature value without a sign and ensure it defaults to negative (note: flight level needs to be inserted prior to only accept temperature entries, otherwise, FL/temp is required).
Insert a positive value and verify a positive sign is shown.
Insert a value of 0 and verify no sign is shown.
Insert a negative value with the - sign and verify it is inserted correctly.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.