Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move images to new bot repo #92

Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

benw202
Copy link
Member

@benw202 benw202 commented Nov 5, 2024

Description

Work in Progress:

52 Commands currently have images.

50 images in this PR (53 in total - disregard one for the new profile picture, one command has two images and one is a full quality imaged that isn't used)

Missing 3 images

  • A380X Checklist
  • Unknown
  • Unknown

This PR
/ adds moves all images from the old bot repo to the new bot repo. Images under A32nx have now been put into a generic Aircraft folder. It is undecided if the Aircraft directory should be further split to A32nx, A380x and general.

Changes need to be made in the database to accommodate this. One change to change the base URL from https://assets.discord.flybywirecdn.com/assets/images/... to https://assets.discord.flybywirecdn.com/utils/assets/images/prefix/.... And one to change any image URL including the a32nx directory to the aircraft directory. I have scripts prepared which need to be run when this PR is merged (Production and Staging). See an example of the change below:

Original URL: https://assets.discord.flybywirecdn.com/assets/images/a32nx/screens.png

New URL: https://assets.discord.flybywirecdn.com/utils/assets/images/prefix/aircraft/screens.png


This PR also updates the profile picture of the production bot

Test Results

N/A

Discord Username

benw8484

@benw202 benw202 added the do not merge Don't merge this PR label Nov 5, 2024
@benw202
Copy link
Member Author

benw202 commented Nov 5, 2024

Do not merge label added as DB changes must be made simultaneously

@benw202 benw202 self-assigned this Nov 5, 2024
@benw202 benw202 changed the title profile picture feat: move images to new bot repo Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Don't merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant