Some cleanup #44
Annotations
12 warnings
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "win-x64_framework-dependent.zip", "win-x64_self-contained.zip".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
windows-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\WtqWindow.cs(5,23): warning S4035: Seal class 'WtqWindow' or implement 'IEqualityComparer<T>' instead. (https://rules.sonarsource.com/csharp/RSPEC-4035) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Data\WtqRect.cs(61,6): warning S1244: Do not check floating point equality with exact values, use a range instead. (https://rules.sonarsource.com/csharp/RSPEC-1244) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Data\WtqRect.cs(62,6): warning S1244: Do not check floating point equality with exact values, use a range instead. (https://rules.sonarsource.com/csharp/RSPEC-1244) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Data\WtqRect.cs(63,10): warning S1244: Do not check floating point equality with exact values, use a range instead. (https://rules.sonarsource.com/csharp/RSPEC-1244) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Data\WtqRect.cs(64,11): warning S1244: Do not check floating point equality with exact values, use a range instead. (https://rules.sonarsource.com/csharp/RSPEC-1244) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\WtqService.cs(16,31): warning CA2213: 'WtqService' contains field '_appRepo' that is of IDisposable type 'IWtqAppRepo', but it is never disposed. Change the Dispose method on 'WtqService' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\WtqService.cs(22,18): warning CA2213: 'WtqService' contains field '_lastOpen' that is of IDisposable type 'WtqApp?', but it is never disposed. Change the Dispose method on 'WtqService' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\WtqService.cs(23,18): warning CA2213: 'WtqService' contains field '_open' that is of IDisposable type 'WtqApp?', but it is never disposed. Change the Dispose method on 'WtqService' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Services\WtqAppToggleService.cs(52,28): warning S1172: Remove this unused method parameter 'app'. (https://rules.sonarsource.com/csharp/RSPEC-1172) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
windows-latest
D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Services\WtqAppToggleService.cs(52,14): warning CA1822: Member 'GetDurationMs' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822) [D:\a\windows-terminal-quake\windows-terminal-quake\src\10-Core\Wtq\Wtq.csproj]
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
win-x64_framework-dependent.zip
Expired
|
788 KB |
|
win-x64_self-contained.zip
Expired
|
63 MB |
|