Fix sync node execution for map over lp

[troychiu]

Why are the changes needed?

Currently if you use flyteremote to sync node execution which contains an array node mapping over a lp, you will get an error

KeyError: LAUNCH_PLAN:troy:development:test_map_over_lp_wf_lp:C1GSRMqmqY7BTENEicqP0A

What changes were proposed in this pull request?

Add case for map over lp in sync node execution.

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Summary by Bito

This PR addresses a bug in FlyteRemote's node execution synchronization by implementing proper handling of launch plan references within array nodes. The changes include improved type hints and interface-based execution synchronization, ensuring correct processing of array nodes containing workflow nodes with launch plan references.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 2

[flyte-bot]

Code Review Agent Run Status

• Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

[flyte-bot]

Code Review Agent Run Status

• Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

[codecov]

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.59%. Comparing base (93c87c3) to head (de622c7).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
flytekit/remote/remote.py	0.00%	12 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3151      +/-   ##
==========================================
- Coverage   78.18%   76.59%   -1.60%     
==========================================
  Files         211      211              
  Lines       21994    22008      +14     
  Branches     2862     2865       +3     
==========================================
- Hits        17195    16856     -339     
- Misses       3960     4361     +401     
+ Partials      839      791      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[flyte-bot]

Code Review Agent Run #f8d228

Actionable Suggestions - 4

• flytekit/models/core/workflow.py - 1

  • Consider adding property decorator to getter · Line 748-748
• flytekit/remote/remote.py - 3

  • Consider extracting array node check logic · Line 500-507
  • Consider validating interface before usage · Line 2631-2631
  • Consider handling None interface case · Line 2644-2644

Review Details

• Files reviewed - 3 · Commit Range: 8ba253c..de622c7

  • flytekit/models/core/workflow.py
  • flytekit/remote/entities.py
  • flytekit/remote/remote.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

AI Code Review powered by

[flyte-bot]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Bug Fix - Fix Array Node Execution Sync for Launch Plans	- workflow.py - Added type hints for launchplan_ref method - entities.py - Added return type hint for FlyteArrayNode - remote.py - Implemented support for syncing array nodes with launch plan references

[eapolinario]

LGTM. I left a comment about a breaking change, but no need to be more accommodating other than just list it in the changelog.

[eapolinario]

this is a breaking change, right? We should call it out in the changelog.

[troychiu]

Yes! Thank you for catching this.