-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add httpx dependency for webhook agent in flytekit dependency #3158
Conversation
Signed-off-by: Future-Outlier <[email protected]>
Code Review Agent Run #2de2f5Actionable Suggestions - 0Review Details
|
Changelist by BitoThis pull request implements the following key changes.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3158 +/- ##
=======================================
Coverage 83.58% 83.58%
=======================================
Files 3 3
Lines 195 195
=======================================
Hits 163 163
Misses 32 32 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Code Review Agent Run #bddc3aActionable Suggestions - 1
Review Details
|
pyproject.toml
Outdated
"httpx", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding version constraints to the httpx
dependency in the optional dependencies section. This helps ensure compatibility and reproducible builds.
Code suggestion
Check the AI-generated fix before applying
"httpx", | |
] | |
"httpx>=0.24.0", | |
] |
Code Review Run #bddc3a
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Code Review Agent Run #e0c684Actionable Suggestions - 4
Review Details
|
Code Review Agent Run #727732Actionable Suggestions - 0Additional Suggestions - 1
Review Details
|
Tracking issue
Why are the changes needed?
we want to enable user to install agent in flytekit by
pip install flytekit[agent]
.What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR includes two main components: 1) Restructuring Flytekit's dependency management by moving httpx and other dependencies to the optional 'agent' extras package, improving webhook agent functionality and error handling. 2) Enhancing FlyteTask configuration with support for security context, kubernetes pod settings, SQL configurations, and extended resources, along with improved testing framework.Unit tests added: True
Estimated effort to review (1-5, lower is better): 2