issue-717: Android widget layout improvements #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
geosaaga
commented
Dec 13, 2024
•
geosaaga
commented
- Widgets use full space without large empty margings
- New layouts work correctly only in light mode. Dark/automatic mode will be implemented in Improve Android widget theme handling #728
- Crisis message removed from small widgets, because couldn't get it work there easily
stembitf
suggested changes
Dec 19, 2024
There was a problem hiding this comment.
The layout of location text, weather icon and temperature text does not look right horizontally:
The layout in Figma design (Android horizontal widget) looks better horizontally:
There was a problem hiding this comment.
Good point, have to be changed to 2 column layout instead of 3 columns currently. I created ticket #739
|
I created tickets for the required improvements and merged this so that the testing can start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.