-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jazzy changes for second edition of the book #36
Conversation
Signed-off-by: Juancams <[email protected]>
Signed-off-by: Juancams <[email protected]>
Signed-off-by: Juancams <[email protected]>
Signed-off-by: Juancams <[email protected]>
Signed-off-by: Juancams <[email protected]>
Signed-off-by: Juancams <[email protected]>
Signed-off-by: Juancams <[email protected]>
Signed-off-by: Juancams <[email protected]>
Signed-off-by: Juancams <[email protected]>
Signed-off-by: Juancams <[email protected]>
Thanks @Juancams Merging!!! 🚀 |
That looks more complete than my minimal change to the 3rd-Party libraries. I haven't run into the other issues yet, but I'll keep them in mind. The one error that I do get (and haven't yet fixed) is: Do any of the above changes take care of that? |
Hi @AESilky I can't tell you if this is solved in the PR, but if you are working on ROS 2 Jazzy I would recommend updating and checking if the error persists. This error has appeared on several occasions in other packages I work with, but it did not appear in this one. In my workspace it has compiled in both Jazzy and Rolling, and you can see that the CI is also working in both, so I would recommend updating your packages as well. In case neither updating your packages nor updating this branch with the latest PR solves your errors, I recommend you make the following change: #include "cv_bridge/cv_bridge.hpp" Also, open a new issue with this error, to see if there are more users who have this problem, and if so, make a PR with the solution I mentioned. I hope it helps you. Greetings. |
Hello!
After checking all the packages, I'm leaving here the most important changes to make everything work.
third_parties.repos
to use tiago_harmonic branches.br2_tracking
.tiago_navigation.launch.py
to useslam_params_file
andtwist_stamper
. Also addedrviz
parameter.br2_bt_patrolling
.I hope everything is working properly.
Regards.