Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzy changes for second edition of the book #36

Merged
merged 10 commits into from
Nov 6, 2024

Conversation

Juancams
Copy link
Contributor

@Juancams Juancams commented Nov 6, 2024

Hello!

After checking all the packages, I'm leaving here the most important changes to make everything work.

  • Updated third_parties.repos to use tiago_harmonic branches.
  • Updated CI to work properly on jazzy.
  • Changed head speed for br2_tracking.
  • Updated tiago_navigation.launch.py ​​ to use slam_params_file and twist_stamper. Also added rviz parameter.
  • Updated navigation parameters.
  • Changed wp, map and test for br2_bt_patrolling.

I hope everything is working properly.

Regards.

@fmrico
Copy link
Owner

fmrico commented Nov 6, 2024

Thanks @Juancams

Merging!!! 🚀

@fmrico fmrico merged commit 193371a into fmrico:jazzy-devel Nov 6, 2024
1 check passed
@fmrico fmrico mentioned this pull request Nov 8, 2024
@AESilky
Copy link

AESilky commented Nov 9, 2024

That looks more complete than my minimal change to the 3rd-Party libraries. I haven't run into the other issues yet, but I'll keep them in mind. The one error that I do get (and haven't yet fixed) is:
fatel error: cv_bridge/cv_bridge.h: No such file or directory

Do any of the above changes take care of that?

@Juancams
Copy link
Contributor Author

Juancams commented Nov 9, 2024

Hi @AESilky

I can't tell you if this is solved in the PR, but if you are working on ROS 2 Jazzy I would recommend updating and checking if the error persists.

This error has appeared on several occasions in other packages I work with, but it did not appear in this one. In my workspace it has compiled in both Jazzy and Rolling, and you can see that the CI is also working in both, so I would recommend updating your packages as well.

In case neither updating your packages nor updating this branch with the latest PR solves your errors, I recommend you make the following change:

#include "cv_bridge/cv_bridge.hpp"

Also, open a new issue with this error, to see if there are more users who have this problem, and if so, make a PR with the solution I mentioned.

I hope it helps you.

Greetings.

@Juancams Juancams mentioned this pull request Nov 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants