Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERM-3436 When exporting a KBART file, the column date_last_issue_onli… #836

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

CalamityC
Copy link
Contributor

…ne should not contain a NULL value in case there is no end year

  • make date_last_issue_online null safe in KBart.groovy

…ne should not contain a NULL value in case there is no end year

* make date_last_issue_online null safe in KBart.groovy
Copy link

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

Copy link

github-actions bot commented Nov 25, 2024

Test Results

142 tests  ±0   138 ✅ ±0   5m 28s ⏱️ -10s
 17 suites ±0     4 💤 ±0 
 17 files   ±0     0 ❌ ±0 

Results for commit c83676e. ± Comparison against base commit 62531da.

♻️ This comment has been updated with latest results.

@CalamityC CalamityC marked this pull request as ready for review November 27, 2024 13:29
Copy link
Contributor

@EthanFreestone EthanFreestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be null safe-ing all these fields probably, but at least both date fields

EthanFreestone and others added 3 commits December 2, 2024 15:04
…ne should not contain a NULL value in case there is no end year

* make all kbartclone fields null safe
@EthanFreestone EthanFreestone merged commit 2390adf into master Dec 4, 2024
11 checks passed
@EthanFreestone EthanFreestone deleted the erm-3436 branch December 4, 2024 09:09
Jack-Golding pushed a commit that referenced this pull request Dec 6, 2024
#836)

* ERM-3436 When exporting a KBART file, the column date_last_issue_online should not contain a NULL value in case there is no end year

* make date_last_issue_online null safe in KBart.groovy

* ERM-3436 When exporting a KBART file, the column date_last_issue_online should not contain a NULL value in case there is no end year

* make all kbartclone fields null safe

---------

Co-authored-by: EthanFreestone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants