Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: pushPkg endpoint in mod-agreements works unexpectedly slowly #839

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

EthanFreestone
Copy link
Contributor

Impropve transaction handling in a couple of key areas to facilitate pushPkg functionality -- matches changes made in ingest process and for pushPCI previously

ERM-3455

Impropve transaction handling in a couple of key areas to facilitate pushPkg functionality -- matches changes made in ingest process and for pushPCI previously

ERM-3455
Copy link

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

Copy link

github-actions bot commented Nov 28, 2024

Test Results

142 tests  ±0   138 ✅ ±0   5m 32s ⏱️ -10s
 17 suites ±0     4 💤 ±0 
 17 files   ±0     0 ❌ ±0 

Results for commit 1ad22a3. ± Comparison against base commit 6359462.

♻️ This comment has been updated with latest results.

@EthanFreestone EthanFreestone merged commit a8fc66f into master Nov 28, 2024
11 checks passed
@EthanFreestone EthanFreestone deleted the ERM-3455 branch November 28, 2024 12:13
Jack-Golding pushed a commit that referenced this pull request Nov 29, 2024
#839)

* perf: pushPkg endpoint in mod-agreements works unexpectedly slowly

Impropve transaction handling in a couple of key areas to facilitate pushPkg functionality -- matches changes made in ingest process and for pushPCI previously

ERM-3455

* fix: Remove special Org transaction handling as it causes int tests to crash (Perf seems to be fine enough without it)

* fix: Reinstated flushes in coordinateOrg, turns out they were necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant