MCBFF-21 Request types - failsafe approach for ECS requesting #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. removed plural from collection name
# Conflicts: # descriptors/ModuleDescriptor-template.json # src/main/java/org/folio/circulationbff/client/feign/CirculationClient.java # src/main/java/org/folio/circulationbff/client/feign/EcsTlrClient.java # src/main/java/org/folio/circulationbff/controller/CirculationBffController.java # src/main/java/org/folio/circulationbff/service/CirculationBffService.java # src/main/java/org/folio/circulationbff/service/impl/CirculationBffServiceImpl.java # src/main/resources/swagger.api/paths/staffSlips/pickSlips.yaml # src/main/resources/swagger.api/paths/staffSlips/searchSlips.yaml # src/test/java/org/folio/circulationbff/api/StaffSlipApiTest.java # src/test/java/org/folio/circulationbff/api/StaffSlipsApiTestDataProvider.java # src/test/java/org/folio/circulationbff/controller/CirculationBffControllerTest.java
# Conflicts: # src/main/java/org/folio/circulationbff/client/feign/EcsTlrClient.java # src/main/java/org/folio/circulationbff/controller/CirculationBffController.java # src/main/java/org/folio/circulationbff/service/impl/CirculationBffServiceImpl.java # src/main/java/org/folio/circulationbff/service/impl/SettingsServiceImpl.java # src/main/java/org/folio/circulationbff/service/impl/UserTenantsServiceImpl.java
AntonAntonich
changed the title
src/main/java/org/folio/circulationbff/service/impl/EcsRequestExternalServiceImpl.java
Show resolved
Hide resolved
src/main/resources/swagger.api/paths/ecsRequestExternal/ecsRequestExternal.yaml
Outdated
Show resolved
Hide resolved
src/test/java/org/folio/circulationbff/api/EcsExternalRequestApiTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/folio/circulationbff/api/EcsExternalRequestApiTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/folio/circulationbff/api/EcsExternalRequestApiTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/folio/circulationbff/service/SettingServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/folio/circulationbff/service/SettingServiceTest.java
Outdated
Show resolved
Hide resolved
roman-barannyk
approved these changes
Nov 27, 2024
…o MCBFF-21 # Conflicts: # descriptors/ModuleDescriptor-template.json
|
imerabishvili
approved these changes
Dec 5, 2024
alexanderkurash
approved these changes
Dec 5, 2024
OleksandrVidinieiev
pushed a commit
that referenced
this pull request
Dec 9, 2024
* MCBFF-12: staff slips endpoints. * MCBFF-12: ModuleDescriptor-template.json * MCBFF-12: sonar issues * MCBFF-12: removed "staff" * MCBFF-12: add "staff" in Unit Tests * MCBFF-12: add "staff" when it necessary * MCBFF-12: deleted staffSlipsCommon.yaml * MCBFF-12: added dependencies to mod-tlr and mod-circulation interfaces. removed plural from collection name * MCBFF-12: removed quotes * MCBFF-12: add logic for checking is tenantId central * MCBFF-12: UT refactored * MCBFF-12: add coverage * MCBFF-12: add coverage * MCBFF-12: refactored * MCBFF-12: refactored * MCBFF-12: refactored * MCBFF-12: staff slips split into search and pick * MCBFF-12: staff slips split into search and pick * MCBFF-12: urls. arrays naming * MCBFF-12: test data provider methods naming * MCBFF-12: increased openapi-generator version to 7.9.0 * MCBFF-12: added necessary permissions * MCBFF-12: added necessary permissions * MCBFF-12: user-tenants dependency as required * MCBFF-12: decreased openapi codegen version to previous. removed proxy yaml schema * MCBFF-12: refactored empty lines * MCBFF-12: changed logic with routing * MCBFF-12: UT refactored * MCBFF-12: removed unnecessary logic * MCBFF-12: removed unnecessary permissions * MCBFF-12 Refactor * MCBFF-12: refactored * MCBFF-12: refactored unit tests naming * MCBFF-21: ModuleDescriptor-template.json * MCBFF-21: structure * MCBFF-21: implementation * MCBFF-21: UT * MCBFF-21: resolved conflicts * MCBFF-21: refactored after review * MCBFF-21: refactored tabulation * MCBFF-21: refactored * MCBFF-21: refactored * MCBFF-21: refactored * MCBFF-21: refactored permission naming --------- Co-authored-by: alexanderkurash <[email protected]> Co-authored-by: Roman_Barannyk <[email protected]> (cherry picked from commit b9664c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use new endpoint from mod-tlr for creating external ecs request
Jira ticket:
MCBFF-21