-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCBFF-37: Check-in API #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderkurash
approved these changes
Jan 10, 2025
Quality Gate passedIssues Measures |
imerabishvili
approved these changes
Jan 13, 2025
roman-barannyk
pushed a commit
that referenced
this pull request
Jan 16, 2025
* MCBFF-37 Declare check-in endpoint in module descriptor * MCBFF-37 Declare check-in endpoint in circulation-bff.yaml * MCBFF-37 Controller, service and API test * MCBFF-37 Check-in client, extend request & response schemas, API tests * MCBFF-37 Remove public access modifier * MCBFF-37 Add 400 * MCBFF-37 Forward circulation check-in errors * MCBFF-37 Add permission set * MCBFF-37 Add dependency on interface `circulation` * MCBFF-37 Remove unused imports (cherry picked from commit eb1135f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create a proxy endpoint for mod-circulation's Check-in API.
MCBFF-37
Approach
How does this change fulfill the purpose?
TODOS and Open Questions
Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.