-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCBFF-38: Update hardcoded effective location during checkin #47
Changes from 3 commits
131db36
ae4a787
c70dcf4
0e725cd
a967e5e
574aeb3
b6df732
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package org.folio.circulationbff.service; | ||
|
||
import org.folio.circulationbff.domain.dto.Item; | ||
import org.folio.circulationbff.domain.dto.ServicePoint; | ||
|
||
public interface InventoryService { | ||
Item fetchItem(String id); | ||
ServicePoint fetchServicePoint(String id); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,76 @@ | ||
package org.folio.circulationbff.service.impl; | ||
|
||
import lombok.RequiredArgsConstructor; | ||
import lombok.extern.log4j.Log4j2; | ||
import org.folio.circulationbff.client.feign.CheckInClient; | ||
import org.folio.circulationbff.domain.dto.CheckInRequest; | ||
import org.folio.circulationbff.domain.dto.CheckInResponse; | ||
import org.folio.circulationbff.domain.dto.SearchItem; | ||
import org.folio.circulationbff.service.CheckInService; | ||
import org.folio.circulationbff.service.InventoryService; | ||
import org.folio.circulationbff.service.SearchService; | ||
import org.folio.circulationbff.service.UserTenantsService; | ||
import org.folio.spring.service.SystemUserScopedExecutionService; | ||
import org.springframework.stereotype.Service; | ||
|
||
import lombok.RequiredArgsConstructor; | ||
import lombok.extern.log4j.Log4j2; | ||
import java.util.Objects; | ||
|
||
@Service | ||
@RequiredArgsConstructor | ||
@Log4j2 | ||
public class CheckInServiceImpl implements CheckInService { | ||
|
||
private final CheckInClient checkInClient; | ||
private final SearchService searchService; | ||
private final UserTenantsService userTenantsService; | ||
private final InventoryService inventoryService; | ||
private final SystemUserScopedExecutionService executionService; | ||
|
||
@Override | ||
public CheckInResponse checkIn(CheckInRequest request) { | ||
log.info("checkIn: checking in item with barcode {} on service point {}", | ||
request::getItemBarcode, request::getServicePointId); | ||
return checkInClient.checkIn(request); | ||
request.getItemBarcode(), request.getServicePointId()); | ||
var response = checkInClient.checkIn(request); | ||
var item = response.getItem(); | ||
var servicePointName = getEffectiveLocationServicePoint(item.getId()); | ||
if (servicePointName != null) { | ||
var slipContextItem = response.getStaffSlipContext().getItem(); | ||
slipContextItem.setEffectiveLocationPrimaryServicePointName(servicePointName); | ||
slipContextItem.toServicePoint(servicePointName); | ||
} | ||
return response; | ||
} | ||
|
||
private String getEffectiveLocationServicePoint(String itemId) { | ||
log.info("getEffectiveLocationServicePoint: itemId {}", itemId); | ||
var instance = searchService.findInstanceByItemId(itemId); | ||
if (instance == null) { | ||
log.warn("getEffectiveLocationServicePoint: instance not found"); | ||
return null; | ||
} | ||
var itemTenantId = instance.getItems() | ||
.stream() | ||
.filter(item -> item.getId().equals(itemId)) | ||
.findFirst() | ||
.map(SearchItem::getTenantId) | ||
.orElse(null); | ||
if (Objects.equals(itemTenantId, userTenantsService.getCurrentTenant())) { | ||
imerabishvili marked this conversation as resolved.
Show resolved
Hide resolved
|
||
log.info("getEffectiveLocationServicePoint: same tenant case {}", itemTenantId); | ||
var item = inventoryService.fetchItem(itemId); | ||
var servicePoint = inventoryService.fetchServicePoint(item.getEffectiveLocationId()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. effectiveLocationId is different from servicePointId There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||
return servicePoint.getName(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add logging of the result |
||
} else { | ||
log.info("getEffectiveLocationServicePoint: cross tenant case {}", itemTenantId); | ||
var item = executionService.executeSystemUserScoped( | ||
itemTenantId, | ||
() -> inventoryService.fetchItem(itemId) | ||
); | ||
var servicePoint = executionService.executeSystemUserScoped( | ||
itemTenantId, | ||
() -> inventoryService.fetchServicePoint(item.getEffectiveLocationId()) | ||
); | ||
return servicePoint.getName(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add logging of the result, check if location is not null |
||
} | ||
} | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
package org.folio.circulationbff.service.impl; | ||
|
||
import lombok.RequiredArgsConstructor; | ||
import lombok.extern.log4j.Log4j2; | ||
import org.folio.circulationbff.client.feign.ItemStorageClient; | ||
import org.folio.circulationbff.client.feign.ServicePointClient; | ||
import org.folio.circulationbff.domain.dto.Item; | ||
import org.folio.circulationbff.domain.dto.ServicePoint; | ||
import org.folio.circulationbff.service.InventoryService; | ||
import org.springframework.stereotype.Service; | ||
|
||
@Service | ||
@RequiredArgsConstructor | ||
@Log4j2 | ||
public class InventoryServiceImpl implements InventoryService { | ||
private final ItemStorageClient itemClient; | ||
private final ServicePointClient servicePointClient; | ||
|
||
@Override | ||
public Item fetchItem(String id) { | ||
log.info("fetchItem:: fetching item {}", id); | ||
return itemClient.findItem(id); | ||
} | ||
|
||
@Override | ||
public ServicePoint fetchServicePoint(String id) { | ||
log.info("fetchServicePoint:: fetching service point {}", id); | ||
return servicePointClient.findServicePoint(id); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -14,6 +14,7 @@ | |||||
import java.util.function.Function; | ||||||
import java.util.stream.Collectors; | ||||||
|
||||||
import org.apache.commons.collections4.CollectionUtils; | ||||||
import org.apache.commons.lang3.StringUtils; | ||||||
import org.folio.circulationbff.client.feign.HoldingsStorageClient; | ||||||
import org.folio.circulationbff.client.feign.InstanceStorageClient; | ||||||
|
@@ -71,6 +72,17 @@ public class SearchServiceImpl implements SearchService { | |||||
private final BulkFetchingService fetchingService; | ||||||
private final SearchInstanceMapper searchInstanceMapper; | ||||||
|
||||||
@Override | ||||||
public SearchInstance findInstanceByItemId(String itemId) { | ||||||
log.info("findInstanceByItemId:: itemId {}", itemId); | ||||||
String query = "items.id==" + itemId; | ||||||
SearchInstances searchResult = searchClient.findInstances(query, true); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated |
||||||
if (CollectionUtils.isEmpty(searchResult.getInstances())) { | ||||||
return null; | ||||||
} | ||||||
return searchResult.getInstances().get(0); | ||||||
} | ||||||
|
||||||
@Override | ||||||
public Collection<BffSearchInstance> findInstances(String query) { | ||||||
log.info("findInstances:: searching instances by query: {}", query); | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the same for item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need
user-tenants.item.get
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a rule that if we add a permission for an item, we need to add a similar one for the collection, and vice versa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not find
user-tenants.item.get
anywhere in folio-org. Does it exists?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, it exists only for consortia.user-tenants.item.get, so ignore it then