Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add validate module github action script #271

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Conversation

EthanFreestone
Copy link
Contributor

No description provided.

Copy link

"Permission name is not valid",
"licenses.compareTerms"

"Permission name is not valid",
"licenses.licenses.item.clone"

"Permission name is not valid",
"licenses.admin.action"

"Permission protects more than one endpoint",
"licenses.licenses.collection.get [/licenses/amendments [GET], /licenses/licenses [GET]]"

"Permission protects more than one endpoint",
"licenses.licenses.item.delete [/licenses/amendments/{id} [DELETE], /licenses/licenses/{id} [DELETE]]"

"Permission protects more than one endpoint",
"licenses.licenses.item.clone [/licenses/amendments/{id}/clone [POST], /licenses/licenses/{id}/clone [POST]]"

"Permission protects more than one endpoint",
"licenses.licenses.item.post [/licenses/amendments [POST], /licenses/licenses [POST]]"

"Permission protects more than one endpoint",
"licenses.refdata.collection.get [/licenses/refdata/{domain}/{property} [GET], /licenses/refdata [GET]]"

"Permission protects more than one endpoint",
"licenses.licenses.item.put [/licenses/licenses/{id} [PUT], /licenses/amendments/{id} [PUT]]"

"Permission protects more than one endpoint",
"licenses.custprops.collection.get [/licenses/custprops [GET], /licenses/custprops/contexts [GET]]"

"Permission protects more than one endpoint",
"licenses.licenses.item.get [/licenses/licenses/{id} [GET], /licenses/amendments/{id} [GET]]"

Copy link

"Permission name is not valid",
"licenses.compareTerms"

"Permission name is not valid",
"licenses.admin.action"

"Permission protects more than one endpoint",
"licenses.licenses.collection.get [/licenses/amendments [GET], /licenses/licenses [GET]]"

"Permission protects more than one endpoint",
"licenses.licenses.item.delete [/licenses/amendments/{id} [DELETE], /licenses/licenses/{id} [DELETE]]"

"Permission protects more than one endpoint",
"licenses.licenses.item.post [/licenses/amendments [POST], /licenses/licenses [POST]]"

"Permission protects more than one endpoint",
"licenses.refdata.collection.get [/licenses/refdata/{domain}/{property} [GET], /licenses/refdata [GET]]"

"Permission protects more than one endpoint",
"licenses.licenses.item.put [/licenses/licenses/{id} [PUT], /licenses/amendments/{id} [PUT]]"

"Permission protects more than one endpoint",
"licenses.custprops.collection.get [/licenses/custprops [GET], /licenses/custprops/contexts [GET]]"

"Permission protects more than one endpoint",
"licenses.licenses.item.get [/licenses/licenses/{id} [GET], /licenses/amendments/{id} [GET]]"

Copy link

"Permission name is not valid",
"licenses.compareTerms"

"Permission name is not valid",
"licenses.admin.action"

"Permission protects more than one endpoint",
"licenses.refdata.collection.get [/licenses/refdata/{domain}/{property} [GET], /licenses/refdata [GET]]"

"Permission protects more than one endpoint",
"licenses.custprops.collection.get [/licenses/custprops [GET], /licenses/custprops/contexts [GET]]"

@EthanFreestone EthanFreestone marked this pull request as draft September 25, 2024 08:52
Copy link

"Permission name is not valid",
"licenses.compareTerms"

"Permission name is not valid",
"licenses.admin.action"

"Permission protects more than one endpoint",
"licenses.custprops.collection.get [/licenses/custprops [GET], /licenses/custprops/contexts [GET]]"

Copy link

"Permission name is not valid",
"licenses.compareTerms"

"Permission name is not valid",
"licenses.admin.action"

Copy link

"Permission name is not valid",
"licenses.compareTerms"

@folio-org folio-org deleted a comment from github-actions bot Sep 25, 2024
EthanFreestone added a commit to folio-org/mod-agreements that referenced this pull request Sep 25, 2024
EthanFreestone added a commit to folio-org/mod-agreements that referenced this pull request Oct 1, 2024
* ci: Turn on validate workflow in order to change module descriptor perms to fit Eureka shape

* ci: Format JSON in ModuleDescriptor

* chore: Bring refdata perms in line with licenses PR: folio-org/mod-licenses#271

* chore: Bring custom properties permissions in line with licenses PR

* docs: Added section to README about how to run the validator locally should a developer wish to do so

* chore: Change clone permission to match licenses PR

* chore: Change `erm.admin.action` to match licenses PR (No group so is likely surfaced elsewhere and may require changes)

* chore: STS permissions cleanup

* chore: Job permission tweaks (Added logging granular perms, added fileobject perm, added logging perm group)

* refactor: Whitsepace change in URLMappings

Not real change, just changing out whitespace for consistency

* chore: Cleanup jobs by type permission

* chore: Cleanup entitlementOptions perms (separate granular permission for static vs dynamic endpoints)

* chore: Added property specific KB validate permission to protect that endpoint

* chore: Tweak to resources on an agreement perms

* chore: Tweak export permission setup -- This feels pretty gross, multiple ways to get exactly the same stuff

* Tweak electronic vs all resource collection get

* chore: Change package content permissions and package sorce get permissions

* chore: Extend to add usage data providers collection perm--need to check that it makes sense to include that in agrement view perm

* chore: Add separate perm for related entitlements

* chore: Log entry permission

Added separate logEntry colleciton permission

* chore: Added separate validate permission for subscription agreement property level endpoint

* chore: linkedLicenses collection permission (Check with Owen whether to include that in permission group or not)

* chore: linkedLicenses collection permission (Check with Owen whether to include that in permission group or not)

* chore: Tweak electronic titles permission

* chore: Add "replaces" for refdata permissions, and dot separates

* chore: Added replaces for erm.admin.action

* chore: All Module Descriptor changes discussed on call with Owen

* chore: More module des descriptor tweaks

* chore: Final module descriptor tweaks

* chore: Accidentally didn't change over all contexts perms to "collection" basis
@EthanFreestone EthanFreestone marked this pull request as ready for review October 1, 2024 14:49
@EthanFreestone EthanFreestone merged commit c3876ab into master Oct 1, 2024
4 checks passed
@EthanFreestone EthanFreestone deleted the ci/validate_md branch October 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant