ERM-3387: Description can be too long for index, causing mod-licenses error when updating from 5.0.x to later versions or failure on saving licenses with a long description #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included a migrations file to run pre-quesnalia migrations. This ensures that any systems coming from Poppy or before with sufficiently large license descriptions can upgrade to Q. Any systems who have _already_ upgraded to Q will have the "wrong" index on license description, and we recommend implementors manage the adding of the correct indexes manually ERM-3387
Accidentally included a comma, that causes broken migrations. Also realised that `"2024-10-17-ERM-3387-quesnalia-1"` and `"2024-10-17-ERM-3387-quesnalia-2"` are not currently running due to preconditions, which likely means the "wrong" gin index definitions are also not running even on systems which successfully upgraded to Q, so the license description really is the only one which matters ERM-3387
EthanFreestone
added a commit
that referenced
this pull request
Oct 18, 2024
… error when updating from 5.0.x to later versions or failure on saving licenses with a long description (#272) * fix: Pre-quesnalia gin index declarations Included a migrations file to run pre-quesnalia migrations. This ensures that any systems coming from Poppy or before with sufficiently large license descriptions can upgrade to Q. Any systems who have _already_ upgraded to Q will have the "wrong" index on license description, and we recommend implementors manage the adding of the correct indexes manually ERM-3387 * fix: Syntax error Accidentally included a comma, that causes broken migrations. Also realised that `"2024-10-17-ERM-3387-quesnalia-1"` and `"2024-10-17-ERM-3387-quesnalia-2"` are not currently running due to preconditions, which likely means the "wrong" gin index definitions are also not running even on systems which successfully upgraded to Q, so the license description really is the only one which matters ERM-3387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pre-quesnalia migration file which intercepts the broken migration by implementing it correctly for systems struggling to upgrade.
It won't run for systems who have already upgraded, and so those will have issues attempting to post sufficiently large license descriptions. Release notes should include description of this issue, and we can help to remedy it with SQL.
(This is left deliberately to implementors, not as automagical migrations, as implementors often include and manage their own indexes in addition to those set up automatically, which we have no insight into)