You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary change to retrieve contents for all fields in entity type definition. This will keep things working until the UI is updated to send desired fields in contents request. This PR also provides support for passing the list of fields to retrieve content for in the GET /lists/contents API, although the UI will need to be updated to support that change.
Fix for MODLISTS-90: Newly selected columns aren't populated with data
@bvsharp can we add a comment somewhere that this is temporary change and it will be changed when UI work is done
Originally I did have a comment for that, but I ended up reworking things so that it'll work right out of the box once the UI is updated to send fields in the request. Which means that this change will actually end up being permanent. But I'll rename the PR in order to reflect that more clearly.
bvsharp
changed the title
Temporarily retrieve contents for all fields in entity type definition
Pass fields in GET /lists/contents request. Retrieve all fields if "fields" parameter is not provided
Mar 13, 2024
@bvsharp can we add a comment somewhere that this is temporary change and it will be changed when UI work is done
Originally I did have a comment for that, but I ended up reworking things so that it'll work right out of the box once the UI is updated to send fields in the request. Which means that this change will actually end up being permanent. But I'll rename the PR in order to reflect that more clearly.
Oh okay. Make sense to me. Thank you for the explanation @bvsharp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bvsharp
force-pushed
the
retrieve-all-fields-from-entity-type
branch
3 times, most recently
from
Purpose
Temporary change to retrieve contents for all fields in entity type definition. This will keep things working until the UI is updated to send desired fields in contents request. This PR also provides support for passing the list of fields to retrieve content for in the GET /lists/contents API, although the UI will need to be updated to support that change.
Fix for MODLISTS-90: Newly selected columns aren't populated with data