[MODPATRON-165]-Added POST api for external patron. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SinghAdes
requested review from
Vignesh-kalyanasundaram,
gurleenkaurbp,
SreejaMangarapu and
a team
| private Set<String> departments; | ||
|
|
||
| @Valid | ||
| private List<String> proxyFor; |
There was a problem hiding this comment.
Please remove unused fields in this class.
| } | ||
|
|
||
| private CompletableFuture<String> getRemotePatronGroupId(UserRepository userRepository, Map<String, String> okapiHeaders) { | ||
| return userRepository.getGroupByGroupName("staff", okapiHeaders) |
There was a problem hiding this comment.
Please use string constant for staff
| JsonObject addressTypes = new JsonObject(); | ||
| responseJson.getJsonArray("addressTypes").forEach(item -> { | ||
| JsonObject addressType = (JsonObject) item; | ||
| if ("Home".equalsIgnoreCase(addressType.getString("addressType"))) { |
There was a problem hiding this comment.
Please use string constants for home and work keywords
| return CompletableFuture.completedFuture( | ||
| PostPatronAccountResponse.respond403WithTextPlain("User does not belong to the required patron group") | ||
| ); | ||
| } |
There was a problem hiding this comment.
Pls check the error response code and error message.
Vignesh-kalyanasundaram
approved these changes
Jun 5, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/MODPATRON-166.
Approach:- In scope of this PR we are creating user based on LOC application requirement .