MODPATRON-156 Validation errors should return 422 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ON-156 # Conflicts: # descriptors/ModuleDescriptor-template.json
roman-barannyk
requested review from
alexanderkurash,
OleksandrVidinieiev and
MagzhanArtykov
roman-barannyk
force-pushed
the
MODPATRON-156
branch
from
47441ff to
73ea3e4
Compare
alexanderkurash
approved these changes
Jun 21, 2024
|
alexanderkurash
approved these changes
Jun 21, 2024
OleksandrVidinieiev
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When mod-patron fails to create a request because circulation rules don't allow it, it returns 500 error code with plain text body (screenshot in the attachment). On production, 500 errors' messages get replaced with a standard message which hides this information from the user.
When validation errors happen, mod-patron should return 422 code with JSON body, formatted in the same way as other errors in FOLIO (errors.schema)
Resolves: MODPATRON-156