Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.3.5 #228

Open
wants to merge 7 commits into
base: b3.3
Choose a base branch
from
Open

Release 3.3.5 #228

wants to merge 7 commits into from

Conversation

julianladisch
Copy link
Contributor

No description provided.

https://folio-org.atlassian.net/browse/MODRS-221

Upgrade Spring boot from 3.3.4 to 3.3.6.

This indirectly upgrades tomcat-embed-core from 10.1.30 to 10.1.33 fixing mix-up of HTTP/2 requests and/or responses between users:

https://www.cve.org/CVERecord?id=CVE-2024-52317

(cherry picked from commit cbc08c9)
https://folio-org.atlassian.net/browse/MODRS-222

Upgrade postgresql client library from 42.6.0 to 42.7.4.

Upgrade zonky embedded.db from 2.5.0 to 2.6.0.

Upgrade postgres test container from 11 to 16 and use TESTCONTAINERS_POSTGRES_IMAGE GitHub Action workflow.

(cherry picked from commit 7360f9d)
https://folio-org.atlassian.net/browse/MODRS-224

Several CQL queries doesn’t mask special characters leading to CQL injection that cause exceptions.

Example:

A slash in inventory item barcode causes this exception:

feign.FeignException$BadRequest: [400 Bad Request] during [GET] to [http://okapi.okapi.svc.cluster.local:9130/inventory/items?query=barcode%3D%3DA%20THE%20086/829-2] [InventoryClient#getItemsByQuery(String)]: [org.folio.cql2pgjson.exception.QueryValidationException: org.z3950.zing.cql.CQLParseException: expected boolean, got '/': barcode==A THE 086/829-2]

Affected characters:

* / slash
* \ backslash
*   space
* " double quotes
* * start
* ? question mark
* ^ caret
* \

And probably others.

Solution:

Use StringUtil.cqlEncode to put the string into quotes and to encode any special CQL character.

Replace any id== query with a /{id} endpoint query to completely avoid any CQL overhead.

(cherry picked from commit 23cff87)
(cherry picked from commit 8bb1e5e)
@julianladisch julianladisch requested a review from a team January 24, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants