STCOR-944 upgrade stripes-* libraries #1590
Merged
+4,305
−3,043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade stripes-* libraries. Refs STCOR-944
Bigtest Unit Test Results189 tests ±0 184 ✅ ±0 6s ⏱️ ±0s Results for commit 1fbb5fa. ± Comparison against base commit c92d889. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
The stripes-config provided by stripes-cli to BigTest sets `useSecureTokens: true` as of folio-org/stripes-cli#350, so we need to provide matching endpoints here as well. This was an interesting lesson in the foibles of committing `yarn.lock` files, as the reason these tests continued to pass until now was that the version of `@folio/stripes-cli` present in the `yarn.lock` file here predated that change. If we had rebuilt our `yarn.lock` at any point after that change, we would have tripped on the tests then, and perhaps noted it for the breaking change that it was. It _was_ intended to be a breaking change -- that's why we're here, after all -- but it was made months ago, and without bumping the major version in stripes-cli at the time. We should have waited to change the config until we bumped the version.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade stripes-* libraries.
Refs STCOR-944