Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIROLES-125] Remove unused sub-permissions and add "manage" permission set. #90

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

ryandberger
Copy link
Member

@ryandberger ryandberger commented Dec 17, 2024

Copy link

github-actions bot commented Dec 17, 2024

Jest Unit Test Results

1 files  ±0  2 suites  ±0   22s ⏱️ -1s
7 tests ±0  7 ✅ ±0  0 💤 ±0  0 ❌ ±0 
8 runs  ±0  8 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit dca0e71. ± Comparison against base commit 9e66664.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to be certain about the delete behavior

@@ -95,7 +99,6 @@
"subPermissions": [
"ui-authorization-roles.settings.view",
"roles.item.delete",
"roles.users.item.delete",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are role assignments automatically deleted by cascade when a role is deleted? If so, fine. If not, then either

  1. this permission needs to stay so that we can issue the requests to delete them, and then delete the role
  2. this permission goes, and we need to add logic in the application to hide the delete button when the user has ui-authorization-roles.settings.delete, AND does not have permission to manage role assignment, AND the role has one or more users assigned

Copy link
Member Author

@ryandberger ryandberger Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the JIRA ticket description UIROLES-125 for roles.users.item.delete:

"NOTE:  the backend handles this... when deleting a role the UI shouldn't (as AFAICT doesn't) first remove role/user assignments associated with the role being deleted."

@ryandberger ryandberger merged commit f964144 into master Dec 19, 2024
16 checks passed
@ryandberger ryandberger deleted the UIROLES-125 branch December 19, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants