-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UIROLES-125] Remove unused sub-permissions and add "manage" permission set. #90
Conversation
ryandberger
commented
Dec 17, 2024
•
edited
Loading
edited
- Fulfills UIROLES-125.
- Removed unused or duplicate permissions.
- Added new "manage" permission set which allows users to view and assign users to roles.
- Enforcement of "manage" permission is handled in [UISAUTHCOM-39] Enforce new "manage" permission set stripes-authorization-components#60.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we need to be certain about the delete behavior
@@ -95,7 +99,6 @@ | |||
"subPermissions": [ | |||
"ui-authorization-roles.settings.view", | |||
"roles.item.delete", | |||
"roles.users.item.delete", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are role assignments automatically deleted by cascade when a role is deleted? If so, fine. If not, then either
- this permission needs to stay so that we can issue the requests to delete them, and then delete the role
- this permission goes, and we need to add logic in the application to hide the delete button when the user has
ui-authorization-roles.settings.delete
, AND does not have permission to manage role assignment, AND the role has one or more users assigned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the JIRA ticket description UIROLES-125 for roles.users.item.delete
:
"NOTE: the backend handles this... when deleting a role the UI shouldn't (as AFAICT doesn't) first remove role/user assignments associated with the role being deleted."
Quality Gate passedIssues Measures |