UIEUS-369-change-reportType-options-for-download simplify return, rem…

…ove required
folio-org · Nov 11, 2024 · 7583f15 · 7583f15
1 parent 420cfca
commit 7583f15
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/src/components/Counter/CounterStatistics.js b/src/components/Counter/CounterStatistics.js
@@ -22,11 +22,7 @@ const CounterStatistics = ({
     const availableReports = getAvailableReports(reports);
     const reportNamesNew = availableReports?.map((cr) => getDownloadCounterReportTypes(cr.release, cr.report)).flat();
 
-    if (reportNamesNew?.length === 0) {
-      return null;
-    } else {
-      return sortBy(reportNamesNew, ['release', 'label']);
-    }
+    return sortBy(reportNamesNew, ['release', 'label']);
   };
 
   const [downloadableReports, setDownloadableReports] = useState(calcDownloadableReportTypes());

diff --git a/src/components/Counter/DownloadRange/DownloadRange.js b/src/components/Counter/DownloadRange/DownloadRange.js
@@ -202,7 +202,7 @@ function DownloadRange({
 DownloadRange.propTypes = {
   downloadableReports: PropTypes.arrayOf(PropTypes.object).isRequired,
   handlers: PropTypes.shape({
-    onDownloadReportMultiMonth: PropTypes.func.isRequired,
+    onDownloadReportMultiMonth: PropTypes.func,
   }).isRequired,
   intl: PropTypes.object,
   udpId: PropTypes.string.isRequired,

diff --git a/src/components/Counter/utils.js b/src/components/Counter/utils.js
@@ -27,9 +27,5 @@ export const getAvailableReports = reports => {
     })
     .map(cr => ({ report: cr.report, release: cr.release }));
 
-  if (availableReports.length === 0) {
-    return null;
-  } else {
-    return uniqWith(availableReports, isEqual);
-  }
+  return uniqWith(availableReports, isEqual);
 };