*DO NOT MERGE* UIIN-3162 *BREAKING* Use browse 1.5 interface that provides new Call Number Browse endpoints.
#2698
Conversation
…all Number Browse endpoints.
Jest Unit Test Statistics 1 files ±0 255 suites ±0 14m 45s ⏱️ +15s For more details on these failures, see this check. Results for commit e751d08. ± Comparison against base commit ebc566d. ♻️ This comment has been updated with latest results. |
BogdanDenis
changed the title
browse 1.5 interface that provides new Call Number Browse endpoints.browse 1.5 interface that provides new Call Number Browse endpoints.
BogdanDenis
force-pushed
the
UIIN-3162
branch
from
de49231 to
70e2943
Compare
| @@ -16,7 +16,7 @@ const useSearchForShadowInstanceTenants = ({ instanceId } = {}) => { | |||
|
|
|||
| const { isLoading, data = {} } = useQuery({ | |||
| queryKey: [namespace, consortium, instanceId], | |||
| queryFn: () => ky.get('search/instances/facets', | |||
| queryFn: () => ky.get('search/call-numbers/facets', | |||
There was a problem hiding this comment.
Is this necessary for useSearchForShadowInstanceTenants?
| qindex: queryIndexes.ITEM_NORMALIZED_CALL_NUMBERS, | ||
| query: fullCallNumber, | ||
| segment: segments.items, |
There was a problem hiding this comment.
This is repeating, let's move it to a variable, like classificationOption.
| const fullCallNumber = getFullCallNumber(r); | ||
|
|
||
| if (r?.totalRecords) { | ||
| return getTargetRecord(fullCallNumber, r, ...commonTargetRecordArgs); |
There was a problem hiding this comment.
Should <MissedMatchItem query={r.fullCallNumber} /> also be changed?
|
Description
BREAKING Use
browse1.5interface that provides new Call Number Browse endpoints.Related PRs
folio-org/stripes-inventory-components#104
Issues
UIIN-3162