Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3194: Detail view of created Instance record is not loaded after saving #2723

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

mariia-aloshyna
Copy link
Contributor

Purpose

Detail view of created Instance record is not loaded after saving. White screen displays in the third pane.
The problem is not reproduced consistently. GET to ‘/search/instances’ returns 0 records right after Instance creation. But instance is actually created.

Approach

  • Make a pre-call to mod-search only if a user is in consortium mode to get info about the instance's tenant and shared status, otherwise make a call right to mod-inventory
  • If a user is in consortium mode and mod-search returns the result with empty data even if the instance was successfully created, then make 3 attempts until there is filled data with a 3-second delay.
  • Update unit tests

Refs

https://folio-org.atlassian.net/browse/UIIN-3194

Screenshots

Copy link

github-actions bot commented Jan 24, 2025

Jest Unit Test Statistics

       1 files  ±0     255 suites  ±0   15m 24s ⏱️ +22s
1 025 tests +1  1 023 ✔️ +1  2 💤 ±0  0 ±0 
1 032 runs  +1  1 030 ✔️ +1  2 💤 ±0  0 ±0 

Results for commit c2294a3. ± Comparison against base commit 9869a36.

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
61.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team January 24, 2025 16:05
@mariia-aloshyna mariia-aloshyna merged commit cf7a882 into master Jan 24, 2025
4 of 5 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UIIN-3194 branch January 24, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants