Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3175: Add Version history pane for Item view component #2728

Closed
wants to merge 2 commits into from

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

  • Display all versions in View history second pane for Item view page. For now it's just a version history button and empty pane.

Approach

  • Created VersionHistory component and use it in ItemView component.
  • Added VersionHistoryButton as lastMenu for item view pane

Refs

UIIN-3175

Screenshots

image

Copy link

github-actions bot commented Feb 3, 2025

Jest Unit Test Statistics

       1 files  ±0     255 suites  ±0   15m 37s ⏱️ +47s
1 028 tests +3  1 026 ✔️ +3  2 💤 ±0  0 ±0 
1 035 runs  +3  1 033 ✔️ +3  2 💤 ±0  0 ±0 

Results for commit 88a2b53. ± Comparison against base commit d553e47.

♻️ This comment has been updated with latest results.

@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team February 3, 2025 12:44
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing translations in VersionHistory are a small but crucial glitch here.

This PR does not add a version history pane as the PR title suggests; it adds an empty, do-nothing placeholder. Even if the version-history API isn't available yet, you can still implement this component, and its corresponding tests, as though that API were available and returned data. Personally, I don't like placeholder stories, but your PO may disagree, and that's not a hill I'm willing to die on.

src/views/VersionHistory/VersionHistory.js Show resolved Hide resolved
src/views/VersionHistory/VersionHistory.js Show resolved Hide resolved
src/views/ItemView.test.js Show resolved Hide resolved
@OleksandrHladchenko1
Copy link
Contributor Author

@zburke Sorry for confusing. Here's the new PR with appropriate task (UIIN-3172). Version history cards will be added with mock data in scope of UIIN-3175. The purpose of newly created PR is to add Version history button and Version history pane, that's it.
Created new PR with taking into account all your comments (userEvent and i18n'ed value for pane title).

Until version-history API is ready, we will be pushing new changes into separate branch UXPROD-4125 and deploying it on our rancher envs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants